Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Allow JavaScript Code Hints only in its context - #11263

Merged
abose merged 1 commit into
adobe:masterfrom
sprintr:fix-php-js-hints
Jun 22, 2015
Merged

Allow JavaScript Code Hints only in its context#11263
abose merged 1 commit into
adobe:masterfrom
sprintr:fix-php-js-hints

Conversation

@sprintr

@sprintr sprintr commented Jun 13, 2015

Copy link
Copy Markdown
Contributor

Fixes a regression I made in #11245 where JavaScript code hints were globally available in a PHP document. This will make sure they are only available inside script tags.

@marcelgerber marcelgerber added this to the Release 1.4 milestone Jun 13, 2015
abose
abose reviewed Jun 14, 2015
View reviewed changes
Comment thread src/extensions/default/JavaScriptCodeHints/main.js Outdated

@abose abose Jun 14, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function name is now misleading. maybe change including usages to isHTMLOrPHPFile(document)
or alternatively move the check to a more localized place.

@sprintr
sprintr force-pushed the fix-php-js-hints branch from ef98bd6 to 6757007 Compare June 14, 2015 16:19
@abose abose self-assigned this Jun 15, 2015
abose
abose reviewed Jun 15, 2015
View reviewed changes
Comment thread src/extensions/default/JavaScriptCodeHints/main.js

@abose abose Jun 15, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to define this as a preference?

@sprintr sprintr Jun 15, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so. These are the only two languages that support inline JS.

@sprintr sprintr Jun 15, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case someone wants to disable JavaScript code hints in PHP, they can use language/php layer to disable them.

@abose abose Jun 15, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsp/asp I remember can do similar js mixin as PHP.

@sprintr sprintr Jun 15, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abose jsp/asp files will be highlighted as html files.

@TomMalbran TomMalbran Jun 15, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is something that could be defined as part of the language in the LanguageManager?

@sprintr
sprintr force-pushed the fix-php-js-hints branch from 6757007 to 016e837 Compare June 15, 2015 16:37
abose added a commit that referenced this pull request Jun 22, 2015
@abose
Merge pull request #11263 from sprintr/fix-php-js-hints
4f7be02 
Allow JavaScript Code Hints only in its context
@abose
abose merged commit 4f7be02 into adobe:master Jun 22, 2015
@abose

abose commented Jun 22, 2015

Copy link
Copy Markdown
Contributor

Looks good. Merging.

@sprintr
sprintr deleted the fix-php-js-hints branch June 23, 2015 19:57
@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@abose abose

Labels

None yet

Projects

None yet

Milestone

Release 1.4

Development

Successfully merging this pull request may close these issues.

4 participants

@sprintr @abose @TomMalbran @marcelgerber