Repository navigation
Add ARIA Code Hints - #12471
Add ARIA Code Hints#12471
Conversation
|
Great addition. Thank you. Would you mind changing the formatting back to the previous style? BTW: did you sign the contributor license agreement (CLA)? |
|
@ingorichter I am not sure what you mean by "previous style". Yes I think I did! |
|
Looking at the diff, you can see that the previous formatting was different. Every entry was in one line. |
|
@ingorichter Ok! |
|
@ingorichter Is my work done here? |
|
@Coder206 The code style are different. Many irrelevant code have been touched in the first commit. Here is the screenshot.
Did you turn on the code beautify/format? Maybe you can turn them off and restore the original format, and try commit again. Thanks. |
| "zu"], | ||
| "global": "true" }, | ||
| "role": { "attribOption": ["alert", "alertdialog", "article", "application", "banner", "button", "checkbox", "columnheader", "combobox", | ||
| "accesskey": { "attribOption": [], "global": "true" }, |
There was a problem hiding this comment.
@twang2218 I thought I did... I am not sure what is going on.
|
@Coder206 I send a pull request in your repo to you to fix the format issue some days ago, could you merge it, so this issue can be fixed? |
|
@twang2218 Ok sounds good. |
|
@twang2218 you need to sign the CLA http://dev.brackets.io/brackets-contributor-license-agreement.html @ingorichter do you have time to review this? |
|
@ficristo ok. It's done. |
|
@Coder206 Could you solve the merge conflicts? |
|
@ficristo I am very confused as to what I have to do know. I have a enabled edits from maintainers. |
|
On your local branch you should merge master in it, solve eventual conflicts and push again your changes. |
|
@ficristo Ok I am wondering why this PR wasn't merged beforehand. |
|
Ping! |
|
If your ping is about this not be merged, keep in mind that at the moment Adobe is focused on Dreamweaver so there isn't much help there. Personally I was thinking @ingorichter would have reviewed this. For the conflicts they happen: you should resolve them. |
a67f9e0 to
8c59732
Compare
|
@ficristo Done! |
zaggino
left a comment
There was a problem hiding this comment.
You need to fix the diff, you merged master incorrectly removing autocomplete options:
1514c98 to
425c481
Compare
The purpose of the code is to add the ARIA code hints for HTML. Before this, there were no code hints for the ARIA spec. This change allows developers to get the ARIA codes while programming.
|
Changes made :) |
|
👍 thanks @Coder206 |
|
Sorry. I somehow missed that |
With the aria-atomic, aria-activedescendant and aria-flowto. Has been compared to WYSIWYG for ARIA, its a match. @RaymondLim Plus added "none" to aria-autocomplete