This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Repository navigation
Use opn instead of open. - #12641
Merged
Merged
Use opn instead of open.#12641
Conversation
Collaborator
|
This line: needs to be changed tovar open = require("opn"); too right?
|
Installed with node@3 and npm install --production
Collaborator
Author
|
@petetnt of course... fixed. |
Contributor
|
I think we need some sort of https://github.com/adobe/brackets-shell/pull/505/files for this one, too, so it works when installed with the .deb file. |
This was referenced Aug 10, 2016
Collaborator
Author
I guess I learn something every day I've opened two PR one for maste and one for linux-1547 branch on brackets-shell |
Contributor
|
LGTM. Also tested this with an installer build on Linux to make sure it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installed with node@3 and npm install --production