This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Repository navigation
Fix the bug where errors during installation of a local .zip file wer… - #12702
Merged
Merged
Conversation
…e always shown as "Unknown internal error"
Collaborator
|
LGTM, but would prefer if |
Contributor
Author
|
In this case, I'm not quite sure what the UI should look like. |
Collaborator
|
I would be okay with just them being separated with a dot, as long as the information doesn't go missing. |
Contributor
Author
Collaborator
|
LGTM, merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

…e always shown as "Unknown internal error"
Fixes #8498.
info.errorsis an array in the format[error1, error2], where every error is another array in the format[errorCode, additionalInfo1, additionalInfo2], so overall,info.errorscould look like[["MISSING_PACKAGE_NAME", "C:/ext.zip"], ["INVALID_VERSION_NUMBER", "invalidver", "C/ext.zip"]].Package.formatError, though, can only handle formatting one error.That's why I decided we only handle the first error in the array (we can only output one error per file), so we don't always get "Unknown internal error" when attempting to install an invalid local .zip file.