Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Adds autofill detail tokens to the autocomplete attribute - #12721

Merged
zaggino merged 3 commits into
adobe:masterfrom
Dandandans:autofill-detail-tokens
Sep 15, 2016
Merged

zaggino merged 3 commits into
adobe:masterfrom
Dandandans:autofill-detail-tokens

Conversation

@Dandandans

Copy link
Copy Markdown
Contributor

Inspired by Jason Grigsby and Christian Heilmann, this update adds autofill detail tokens to the autocomplete attribute.

@zaggino zaggino added this to the Release 1.9 milestone Aug 28, 2016
@Denisov21

Copy link
Copy Markdown
Contributor

Good idea!

@mcdado

mcdado commented Sep 14, 2016 •

Copy link
Copy Markdown

Lovely! I was about to make the same PR since Atom uses this list.

But there is one problem, I think: looking at <input> - HTML | MDN I see that you did not include "on" and "off".

@Dandandans

Dandandans commented Sep 14, 2016 •

Copy link
Copy Markdown
Contributor Author

@mcdado, yes, it's a nice +1 for both Atom and Brackets.

I intended to include the on and off values, but I misread the WHATWG standard for the autofill anchor mantle.

When autocomplete is wearing the autofill anchor mantle, on and off shouldn't be combined with autofill detail tokens — e.g. autocomplete="on street-address".

The values on and off are still part of the spec, even though off's usefulness is debatable, and should be included as values.

Thanks for helping me rethink this!

@zaggino
zaggino merged commit 147e945 into adobe:master Sep 15, 2016
@zaggino

zaggino commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants