This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Repository navigation
set eslints max-len to 120 - #12780
Merged
Merged
Conversation
Collaborator
|
I am totally okay with this. Long lines are hard to follow, on GH editor as they are in Brackets. Might be fixable with |
Collaborator
|
I'm okay too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while 80 might be too narrow in some cases, anything over 120 means you have to scroll horizontally when reviewing pull requests on GH which is a real pain
cc @ficristo @petetnt