Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Folder icon issue - #12850

Closed
jamran7 wants to merge 14 commits into
adobe:masterfrom
ChainsawFist:Folder_icon_issue
Closed

jamran7 wants to merge 14 commits into
adobe:masterfrom
ChainsawFist:Folder_icon_issue

Conversation

@jamran7

@jamran7 jamran7 commented Oct 24, 2016 •

Copy link
Copy Markdown
Contributor

This is the 80% fix. Still need to figure out what will determine if a file is a directory.
Adobe repository: delete this if you are seeing this as a pull request. This is supposed to merge into an independent project.

jamran7 and others added 14 commits September 4, 2016 21:57
Everything is on a single line, it seems adding an extra new line per
new line makes github display it as a single new line. At least that is
my theory until I can see it on github.
double tabulating puts text in a div-like box, I just made it so Chris'
name is like the rest.
Add group member names to About box within Brackets application
…possible solutions but are commented out. Real solution is in project/ProjectModel.js lines 112 to 119

@zaggino zaggino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those readme and "this edition has been edited by" changes don't belong to a pull request


<p class="dialog-message"><!-- $NON-NLS$ -->Copyright 2012 - present Adobe Systems Incorporated and its licensors. All rights reserved.</p>

<p class="dialog-message"><b>This edition has been edited by: Chris, Boyce, James and Logan</b></p>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@petetnt

petetnt commented Oct 24, 2016

Copy link
Copy Markdown
Collaborator

Hi @jamran7,

pretty sure this was already fixed in #12807, correct?

@ficristo

Copy link
Copy Markdown
Collaborator

@jamran7 if you use a fork please never point to "healthDataServerURL": "https://health.brackets.io/healthDataLog" which is the production url for the health report of Brackets.
Block it or change to the dev url instead.
Per first comment closing as this should not be merged here.

@ficristo ficristo closed this Oct 24, 2016
@ficristo

Copy link
Copy Markdown
Collaborator

@jamran7 if you have any question, you are more than welcome to ask them here on github or on slack.
It seems to me you are a group of students that are trying to fix some issues, I don't know if you can, but we are open to discuss the possible solutions.

@petetnt

petetnt commented Oct 24, 2016

Copy link
Copy Markdown
Collaborator

Here's additional contact information:

Slack: Brackets on Slack (You can join by sending a mail to admin@brackets.io with the subject line slack registration request specifying the email addresses you would like to register).
Developers mailing list: http://groups.google.com/group/brackets-dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants