Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

English comments were changed to French - #12905

Merged
swmitra merged 3 commits into
adobe:masterfrom
ceokzoo:patch-1
Jan 17, 2017
Merged

swmitra merged 3 commits into
adobe:masterfrom
ceokzoo:patch-1

Conversation

@ceokzoo

@ceokzoo ceokzoo commented Nov 11, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@ficristo

Copy link
Copy Markdown
Collaborator

Usually French and Japanese translation are handled by Adobe.

@ceokzoo

ceokzoo commented Nov 14, 2016

Copy link
Copy Markdown
Contributor Author

Oh okay. What are the next steps to deal with the translation?

@ficristo

Copy link
Copy Markdown
Collaborator

Patentially waiting someone at Adobe. Sorry but I cannot help more.

@swmitra

swmitra commented Dec 6, 2016

Copy link
Copy Markdown
Collaborator

@ceokzoo Sorry missed this thread. I can't review the actual strings but I am asking our localization team to have a look at it. Once they approve I will merge this PR.

Comment thread samples/fr/Premiers pas/index.html Outdated

<!--
MADE WITH <3 AND JAVASCRIPT
FAIT AVEC <3 ET JAVASCRIPT

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to - 'CRÉÉ AVEC <3 ET JAVASCRIPT'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Comment thread samples/fr/Premiers pas/index.html Outdated

<!--
WHAT IS BRACKETS?
QU'EST-CE QUE <<BRACKETS>>?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QU’EST-CE QUE BRACKETS ? (missing non-breaking space before question mark)

-->

<p>
Bienvenue dans Brackets, un éditeur de code open source qui comprend et facilite la conception de sites web. Il s’agit d’un éditeur à la fois léger et puissant qui intègre des outils visuels directement dans son interface, de sorte que chaque opération peut devenir un véritable jeu d’enfant.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph may be edited like -
‘’ Bienvenue dans Brackets, un éditeur de code open source qui comprend et facilite la conception de sites web. Il s’agit d’un éditeur à la fois léger et puissant qui intègre des outils visuels directement dans son interface, de sorte que chaque opération peut devenir un véritable jeu d’enfant.”

@ceokzoo

ceokzoo commented Jan 15, 2017

Copy link
Copy Markdown
Contributor Author

Updated the file with your suggestions!

@swmitra

swmitra commented Jan 17, 2017

Copy link
Copy Markdown
Collaborator

Merging PR #12905

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants