Repository navigation
fixes 3 failing find-in-files tests - #12973
Conversation
| gotChange = false; | ||
| oldResults = null; | ||
| wasQuickChange = false; | ||
| FindInFiles.searchModel.clear(); |
There was a problem hiding this comment.
Maybe call FindInFiles.clearSearch? It is marked as private method but it seems it is already used outside that file.
There was a problem hiding this comment.
Since we're calling FindInFiles.searchModel.on on the next line, I think calling FindInFiles.searchModel.clear directly is more clearer.
There was a problem hiding this comment.
I don't have strong opinion here and I agree is it a bit odd.
My only doubt is clearSearch reset also findOrReplaceInProgress: I'm not sure how much it is important.
|
The test
|
|
Yeah, one test at a time I guess... I'll check what can fix the others next week when I'll have some free time. |
|
@ficristo ready to merge this one, i'll open another if I manage to fix other tests |
this PR fixes:
on my windows machine
ref: #12951