Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Skip template literals when extracting JS functions - #13038

Merged
petetnt merged 1 commit into
masterfrom
rlim/skip-template-literal
Jan 13, 2017
Merged

petetnt merged 1 commit into
masterfrom
rlim/skip-template-literal

Conversation

@RaymondLim

Copy link
Copy Markdown
Contributor

This fixes #13036.

@swmitra

swmitra commented Jan 12, 2017

Copy link
Copy Markdown
Collaborator

@RaymondLim Is this ready for review?
The tweak in the token filter looks good to me though 👍

@petetnt petetnt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaymondLim

Copy link
Copy Markdown
Contributor Author

@swmitra Yes, it's a simple fix and ready to review.

@swmitra swmitra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petetnt
petetnt merged commit 24c9905 into master Jan 13, 2017
@petetnt

petetnt commented Jan 13, 2017

Copy link
Copy Markdown
Collaborator

Thanks @RaymondLim 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick Edit

3 participants