Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Update Finnish strings.js for (current) 1.9 - #13143

Merged
zaggino merged 2 commits into
adobe:masterfrom
39bit:patch-1
Mar 3, 2017
Merged

zaggino merged 2 commits into
adobe:masterfrom
39bit:patch-1

Conversation

@39bit

@39bit 39bit commented Mar 2, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@39bit 39bit changed the title Update Finnish strings.js for v1.9 Update Finnish strings.js for (current) 1.9 Mar 2, 2017
@zaggino

zaggino commented Mar 2, 2017

Copy link
Copy Markdown
Contributor

@valtlai @petetnt wanna have a look here?

@petetnt petetnt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment

Comment thread src/nls/fi/strings.js Outdated
"FIND_QUERY_PLACEHOLDER" : "Etsi\u2026",
"REPLACE_PLACEHOLDER" : "Korvaa merkkijonolla\u2026",
"BUTTON_REPLACE_ALL" : "Kaikki\u2026",
"BUTTON_REPLACE_BATCH" : "Sarja\u2026",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. Maybe something like "Korjaa erissä" or something, "Erä" sounds kinda weird, "sarja" too.

@valtlai valtlai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, but looks good otherwise.

Comment thread src/nls/fi/strings.js Outdated
"CMD_SHOW_IN_EXPLORER" : "Näytä Resurssienhallinnassa",
"CMD_SHOW_IN_FINDER" : "Näytä Finderissä",
"CMD_SHOW_IN_OS" : "Näytä käyttöjärjestelmässä",
"CMD_SWITCH_PANE_FOCUS" : "Vaihda aktiivinen paneeli",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Vaihda ruudun valinta would be better. (Pane has been translated to ruutu elsewhere.)

Comment thread src/nls/fi/strings.js Outdated
"INSTALL_CANCELED" : "Asennus on peruutettu.",
"VIEW_COMPLETE_DESCRIPTION" : "Näytä täysi kuvaus",
"VIEW_TRUNCATED_DESCRIPTION" : "Näytä katkaistu kuvaus",
"SORT_EXTENSION_METHOD" : "Lajittele laajennukset käyttäen latausmäärää tai päivityspäivämäärää",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Lajittele laajennukset latausmäärän tai päivitysajankohdan mukaan.

Comment thread src/nls/fi/strings.js Outdated
"INVALID_VERSION_NUMBER" : "Paketin versionumero ({0}) on virheellinen.",
"INVALID_BRACKETS_VERSION" : "{APP_NAME}in yhteensopivuuden merkkijono ({0}) on virheellinen.",
"DISALLOWED_WORDS" : "Sanat ({1}) eivät ole sallittuja kentässä {0}.",
"NPM_INSTALL_FAILED" : "npm install -komento epäonnistui: {0}",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to replace a dash with \u2011 (non-breaking hyphen) to prevent line break after it.

Comment thread src/nls/fi/strings.js Outdated
"EXTENSIONS_UPDATES_TITLE" : "Päivitykset",
"EXTENSIONS_SORT_BY" : "Lajittele",
"EXTENSIONS_LAST_UPDATED" : "Päivitetty",
"EXTENSIONS_DOWNLOADS" : "Latausmäärä",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Latauksia.

@petetnt

petetnt commented Mar 3, 2017

Copy link
Copy Markdown
Collaborator

Hi @39bit,

could you sign the CLA so we can merge this in? http://dev.brackets.io/brackets-contributor-license-agreement.html

@39bit

39bit commented Mar 3, 2017

Copy link
Copy Markdown
Contributor Author

I have signed the CLA now. @petetnt

@zaggino
zaggino merged commit e7c419a into adobe:master Mar 3, 2017
@zaggino

zaggino commented Mar 3, 2017

Copy link
Copy Markdown
Contributor
Zaggi@ZAGGI-PC MINGW64 /d/dev/brackets-64/brackets (master)
$ grunt cla-check --user=39bit
Running "cla-check" task
39bit has submitted the contributor license agreement

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants