Repository navigation
Remove normalizeFilename function - #13147
Conversation
|
This construct repeats itself if I have counted right and not missed any difference 5 times over the diff, perhaps and use |
|
Sure! If this fixes the crashes I'll refactor like that. |
|
Anyway, were you able to replicate anything, or is this just a hinch? If it doesn't break any tests I think we could merge this for time being as #11948 doesn't seem to be moving much... |
|
Since people reported crashes in 1.8 that weren't in 1.7, this is the only thing that comes to my mind. |
|
I have a project which, while working on it, definitely crashes Brackets, but I can't replicate this. Sometimes after 5 minutes, sometimes after an hour. So it'd vote the approach of merging it and seeing if there's any change in the reports. |
|
Refactored. After running tests again, they are quite flaky. But I'm not sure if it is because our testsuite or because my PR... |
| function handlePrimePump(path) { | ||
| var fileInfo = createEmptyUpdate(path), | ||
| var fileName = path; | ||
| if (ternServer.projectDir && fileName.indexOf(ternServer.projectDir) === 0) { |
There was a problem hiding this comment.
if you don't mind one last change, for future readability, I'd extract this to _getDenormalizedFilename as this basically reverts _getNormalizedFilename if I'm not mistaken
|
Hi @ficristo , I've run the tests and they all pass on my machine so that thing is fine. |
|
👍 |
Quick hack for #12744, I doubt this is the correct way to fix.
I am only interested to see if this could solve the crashes people are experiencing.
/cc @zaggino