[h1w4y]

Addresses #8028 - Quick View doesn't recognize linear-gradient if no space before it

Updated regex to make whitespace character optional before "linear" or "radial"

// Quick View Always Worked for this
background : linear-gradient(to bottom, black 0%, white 100%);
background : radial-gradient(to bottom, black 0%, white 100%);
background: linear-gradient(to bottom, black 0%, white 100%);
background: radial-gradient(to bottom, black 0%, white 100%);

// Now this Works Too
background :linear-gradient(to bottom, black 0%, white 100%);
background :radial-gradient(to bottom, black 0%, white 100%);

[redmunds]

@HighwayChile This works great. Can you add 2 unit tests: 1 for linear-gradient and 1 for radial-gradient?

[h1w4y]

@redmunds Yes! Perfect opportunity -- I'm just starting to look at how brackets tests are organized.

[redmunds]

Excellent -- let me know if you have any questions.

[redmunds]

@HighwayChile After thinking about this a bit more, instead of making preceding whitespace optional, I think we should add option for a colon. This will eliminate false positives for something like xyz-linear-gradient(...). Will that work?

[h1w4y]

@redmunds hmm, let me look at the regex more closely.

[h1w4y]

@redmunds after looking at the regex more, your suggestion is more readable and better matching. Will try to get some tests in tomorrow. Woohoo!

[h1w4y]

@redmunds ok tests are in

[redmunds]

The most common CSS whitespace style between property and value is prop: val, and the second most popular is no whitespace at all: prop:val so add that case (both here and for radial-gradient).

[redmunds]

@HighwayChile Just 2 more minor comments.

[h1w4y]

@redmunds I used a percentage for the radial values because I got an odd result when using the px values. It looks like when the test.css is read for testing, the px value is interpreted as a percentage value -- then it fails because the test is expecting the px value.

Error: Expected 'radial-gradient(red, white 50%, blue 100%)' to be 'radial-gradient(red, white 20px, blue 40px)'.

I can look into this more if it's helpful. Otherwise, I'll stick with the percentage values.

[redmunds]

Look good. Thanks. Merging.

[h1w4y]

@redmunds Awesome, Thanks!