Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Update zh-cn/strings.js - #8070

Merged
bchintx merged 1 commit into
adobe:masterfrom
fengdi:patch-1
Jul 9, 2014
Merged

bchintx merged 1 commit into
adobe:masterfrom
fengdi:patch-1

Conversation

@fengdi

@fengdi fengdi commented Jun 8, 2014

Copy link
Copy Markdown
Contributor

zh-cn translation FIND_MENU and CMD_FIND_IN_SELECTED

Translation FIND_MENU and CMD_FIND_IN_SELECTED
@fengdi fengdi changed the title Update strings.js Update zh-cn/strings.js Jun 8, 2014
@bchintx bchintx self-assigned this Jun 10, 2014
@bchintx

bchintx commented Jun 10, 2014

Copy link
Copy Markdown
Contributor

@fengdi Thanks for submitting this updated translation.

Before we can accept your changes, can you please submit a Contributors License Agreement, which can be found here: http://dev.brackets.io/brackets-contributor-license-agreement.html

Thanks!

@ingorichter

Copy link
Copy Markdown
Contributor

@fengdi Would you mind signing the Brackets CLA? Otherwise we can't accept your contribution. Thank you.

@fengdi

fengdi commented Jun 24, 2014

Copy link
Copy Markdown
Contributor Author

@ingorichter Thx. I have signed it. Now how can I do? Resubmit it?

@ingorichter

Copy link
Copy Markdown
Contributor

@fengdi Thank you for accepting the CLA. To make it perfect, it would be great to create a PR based on the release branch. Can you please update the comment at the bottom of strings.js with the SHA of the src/nls/root/strings.js file that you based your translation off? Thanks.

@bchintx

bchintx commented Jul 9, 2014

Copy link
Copy Markdown
Contributor

Verified that the CLA was signed and that the build worked. Since we already released, merging into master is fine. Merging...

bchintx added a commit that referenced this pull request Jul 9, 2014
@bchintx
bchintx merged commit d4bce10 into adobe:master Jul 9, 2014
@bchintx

bchintx commented Jul 9, 2014

Copy link
Copy Markdown
Contributor

oh, and I checked and the "Last translated" SHA doesn't change. Looks like the latest translation for this language is still based off of the same cd86e0f9f9 SHA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants