Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Use XML highlighting for .xaml files - #8333

Merged
peterflynn merged 1 commit into
adobe:masterfrom
le717:xaml-highlight
Jul 9, 2014
Merged

peterflynn merged 1 commit into
adobe:masterfrom
le717:xaml-highlight

Conversation

@le717

@le717 le717 commented Jul 7, 2014

Copy link
Copy Markdown
Contributor

For #8331. Also alphabetized array.

@peterflynn

Copy link
Copy Markdown
Member

@le717 I'm not sure if alphabetized is necessarily the right order. Semantic grouping might make more sense, e.g. placing .atom & .rss next to each other. Or at the least, the "core" .xml extension should probably we listed first instead of last...

@le717

le717 commented Jul 8, 2014

Copy link
Copy Markdown
Contributor Author

So what about a more semantic array look like? Perhaps I should just revert the sorting and add the one extension to the end (beginning?) of the array unless the other arrays in the file are already semantically ordered.

@peterflynn

Copy link
Copy Markdown
Member

Some of the other long file extension lists are roughly clustered semantically. I think it's fine to keep the old sort order and put .xaml at the end (though maybe move .xml to the beginning?).

@le717

le717 commented Jul 8, 2014

Copy link
Copy Markdown
Contributor Author

@peterflynn Done. Sorry about messing up the sort order. :\

@peterflynn

Copy link
Copy Markdown
Member

@le717 No worries -- never hurts to explore cleanup ideas!

I think the ".xaml" entry shouldn't have a leading "." though -- but after that this should be good to merge.

@le717

le717 commented Jul 9, 2014

Copy link
Copy Markdown
Contributor Author

Apparently I can't get even a starter bug right...

Change will go up in a few minutes. If you want, I'll rebase and remove these bad commits.

@le717

le717 commented Jul 9, 2014

Copy link
Copy Markdown
Contributor Author

@peterflynn Rebased, ready to go.

@peterflynn

Copy link
Copy Markdown
Member

Perfect! Thanks for the rebase, too. Merging...

peterflynn added a commit that referenced this pull request Jul 9, 2014
Use XML highlighting for .xaml files
@peterflynn
peterflynn merged commit d7c93fc into adobe:master Jul 9, 2014
@mjwsteenbergen

Copy link
Copy Markdown

Wow, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants