Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fix outdated comments in StringUtils truncate() - #8707

Merged
peterflynn merged 2 commits into
adobe:masterfrom
le717:fix-truncate-comments
Aug 11, 2014
Merged

peterflynn merged 2 commits into
adobe:masterfrom
le717:fix-truncate-comments

Conversation

@le717

@le717 le717 commented Aug 9, 2014

Copy link
Copy Markdown
Contributor

I must have stared at this code so much I did not realize they were outdated until right now. 😄

Comment thread src/utils/StringUtils.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you change this to {?string} to indicate that it can return undefined?

@peterflynn

Copy link
Copy Markdown
Member

@le717 Just that one suggestion, looks fine to merge other than that

@le717

le717 commented Aug 11, 2014

Copy link
Copy Markdown
Contributor Author

@peterflynn Done.

@peterflynn

Copy link
Copy Markdown
Member

Looks good -- thanks!

peterflynn added a commit that referenced this pull request Aug 11, 2014
Clean up comments in StringUtils `truncate()`
@peterflynn
peterflynn merged commit 165e459 into adobe:master Aug 11, 2014
@le717
le717 deleted the fix-truncate-comments branch August 12, 2014 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants