Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Remove old preferences system - #9752

Closed
le717 wants to merge 3 commits into
adobe:masterfrom
le717:remove-old-prefs
Closed

le717 wants to merge 3 commits into
adobe:masterfrom
le717:remove-old-prefs

Conversation

@le717

@le717 le717 commented Oct 31, 2014

Copy link
Copy Markdown
Contributor

For #8751.

This also removes PreferencesManager.setValueAndSave(), deprecated by 08e8208 in Sprint 37. In order to prevent a repeat of Quick Open, I removed it in a separate commit in case it needs to be reverted and set my search utility to scan more thoroughly. No known extension usage was discovered.

/cc @dangoor

@le717 le717 mentioned this pull request Oct 31, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove all the usages of this functions in our codebase.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should not touch a scrap of code when I am tired...

Done.

along with any related but now unneeded functions.
@busykai

busykai commented Jan 31, 2015

Copy link
Copy Markdown
Contributor

I guess it's pretty safe to remove the old preference implementation at this point. This PR is not mergeable, but before @le717 actualizes it, we need to decide.

CC @redmunds, @peterflynn

@le717

le717 commented Jan 31, 2015

Copy link
Copy Markdown
Contributor Author

@busykai The outcome of #10412 will effect this.

@ficristo

Copy link
Copy Markdown
Collaborator

Closing in favour of #12720 since is more up-to-date.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants