Skip to content

Add configurable network ID and include it in transaction data binaries when signing #750

Open
Open
Add configurable network ID and include it in transaction data binaries when signing#750
Labels
1latest-compatibility

Description

@d-velev
d-velev
opened on Nov 7, 2018

The network ID is appended to the transaction data that is being signed, meaning that transactions made in one network aren't going to be valid in another. It should be "ae_mainnet" by default

Activity

  1. d-velev
    added
    latest-compatibility
    on Nov 7, 2018
  2. thepiwo
    added
    1
    on Nov 8, 2018

  3. Artur64 commented on Nov 12, 2018

    @Artur64
    Artur64
    on Nov 12, 2018
    Contributor

    @d-velev Could you provide a link to get more information about this?

  4. d-velev commented on Nov 12, 2018

    @d-velev
    d-velev
    on Nov 12, 2018
    ContributorAuthor

    @Artur64 I'm not sure where their signing is happening but this is how they transform their transaction binaries https://github.com/aeternity/epoch/blob/master/apps/aecore/src/aec_governance.erl#L217. So we must sign "ae_mainnet" <> serialized_tx and verify the same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1latest-compatibility

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions