eslint v4 support

Note: I filed this issue within minutes of eslint v4.0.0 being released.

eslint-config-airbnb and eslint-config-airbnb-base do not yet support eslint v4.

If it is easy/possible to support both v3 and v4, we will release a non-major bump of both packages that does so, before releasing a major bump that only supports v4.

This will likely take a few weeks at a minimum.

Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v3 until such time as our configs support v4.

Peer Dep eslint combined v3 and v4 support released:

eslint-plugin-import issue | PR | released as v2.6.0
eslint-plugin-react issue for v7.1.0 release
eslint-plugin-jsx-a11y issue | PR | release (v5.1.0 and v6)
eslint-find-rules issue | released as v30.1
update and publish the base config
update and publish the main config

1.10.0

Any updates to this?

@Geczy

@Geczy I've kept the OP updated; if there's updates, you'd see them here.

Since there are no updates posted, no, there are no updates. Please be patient - the OP said "a few weeks at minimum" and it's not yet been 3.

It would be useful to post somewhere prominent on what would be recommended for new projects and the best way to stay on the 3x branch for eslint.

yarn add eslint@3 for yarn users would go a long way to avoid setup hassles.

Really would like this feature. The ability to use overrides would be awesome!

"overrides": [
  {
    "files": ["src/**/__tests__/*.js"],
    "env": {
      "jest": true
    }
  }
]

Core:

@MFry

@MFry i believe yarn has --peer, such that yarn add eslint-config-airbnb --peer should just work? If not, I'd file a bug on yarn. Note that the existing instructions have no setup hassles with npm.

@EloB i'd strongly discourage you from colocating tests; but I agree that if you're doing so, it's a useful feature to be able to configure eslint with globs.

@ljharb

@ljharb would you be willing to expand on the reason for discouraging test colocation?

i used to be more on the side of separating, and still do at this point. however, i've mostly come around to the idea of keeping them with the source files and eslint is the last thing keeping me from doing so.

i'm interested in your specific thoughts if you'd be willing to share.

@travi

@travi that's really a topic for another thread (feel free to file one); and I have a litany of reasons. However, most of those are moot because "not all tools support glob-based configuration". eslint only added it in v4, babel doesn't, etc.

No updates since 2 weeks ago, it's now been 1 month, any news? Do you guys need help taking this on from contributors?

@ljharb

@ljharb npm3 removed easy install of peer dependencies and the support is not yet available in yarn.
Doing yarn add eslint-config-airbnb --peer would just install the package in your peerdependencies. :(

From NPM:

#6930 (#6565) peerDependencies no longer cause anything to be implicitly installed. Instead, npm will now warn if a packages peerDependencies are missing, but it's up to the consumer of the module (i.e. you) to ensure the peers get installed / are included in package.json as direct dependencies or devDependencies of your package.

@MFry

@MFry ah, i misunderstood what --peer does for yarn. In that case, I don't have an easy solution to install the needed peer deps with yarn - but since npm 5 exists, I'm not sure why you'd need yarn :-)

I'm aware that npm 3+ no longer automatically installs peer deps; that's why the readme of both of our eslint config packages has instructions to do so.

@Geczy no, no help is needed. There's no urgency; and the update will come when it's ready.

@ljharb

@ljharb Hi, this error still occurs when extending from airbnb/legacy. Is this the intention or should it also be updated to remove the top level ecmaFeatures?

@ljharb

@ljharb airbnb/legacy has some issues with v4 still

Thanks, legacy is fixed in 0d938ae and will be released in eslint-config-airbnb-base shortly.

chore(package): update eslint-config-airbnb-base to 11.3.0

Hi, any updates on when the ESLint v4-exclusive versions (v12.0.0 base and v16.0.0 main) will be released? Thanks for all the awesome works!

No updates.

@ljharb

@ljharb is there any version of eslint-config-airbnb that includes the fix for the legacy.js file when introducing eslint v4, ie this patch 0d938ae

I don't think its included in the latest 15.1.0 of eslint-config-airbnb that I can see?

It's automatically included because of the semver range on eslint-config-airbnb-base.

[Deps] allow eslint v3 or v4; update `eslint-plugin-import`

[eslint config] [deps] allow eslint v3 or v4

v16 is now released.

[eslint config] [deps] allow eslint v3 or v4

[Deps] allow eslint v3 or v4; update `eslint-plugin-import`

[eslint config] [deps] allow eslint v3 or v4

Navigation Menu

Repository navigation

eslint v4 support #1447

Note: I filed this issue within minutes of eslint v4.0.0 being released.

21 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

eslint v4 support #1447

Description

Note: I filed this issue within minutes of eslint v4.0.0 being released.

Activity

Geczy commented on Jun 28, 2017

ljharb commented on Jun 28, 2017

MFry commented on Jul 6, 2017

EloB commented on Jul 7, 2017

ljharb commented on Jul 9, 2017

travi commented on Jul 9, 2017

ljharb commented on Jul 9, 2017

Geczy commented on Jul 10, 2017

MFry commented on Jul 10, 2017

ljharb commented on Jul 11, 2017

21 remaining items

mark007 commented on Jul 24, 2017

shaharmor commented on Jul 24, 2017

ljharb commented on Jul 24, 2017

wkurniawan07 commented on Aug 13, 2017

ljharb commented on Aug 13, 2017

mark007 commented on Aug 29, 2017

ljharb commented on Aug 29, 2017

ljharb commented on Oct 6, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions