Repository navigation
Widen time zone display names - #50
Merged
Merged
Conversation
amtwo
commented
Nov 1, 2026
amtwo
commented
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Changes the standard
dbo.TimeZones.DisplayNamecolumn tonvarchar(128). The table script also upgrades existing built-in character columns to Unicode while preserving their current capacity (minimum 128 characters). The new contribution guidance explains why schema fixes must account for existing installations.Related issue
Closes #22
Coding agent & Review agent disclosure
Coding agent details:
--Cody 🤖
Adversarial review details
varcharcolumns, and alias types were addressed. The final review found no actionable findings.How did you test it?
main; onlyCONTRIBUTING.mdandtables/dbo.TimeZones.sqlchange. Confirmed the standardnvarchar(128)definition, capacity-preserving migration paths, alias-type guard, nullability preservation, and no trailing whitespace in changed lines. Repository search found no other variable, parameter, or temporary table definitions needing a width change.sqlcmdis not installed, and Docker engine access was denied after checking the repository's SQL Edge smoke-test guidance.Checklist