Using services in providers, Build got failed while using 'ng build ---aot'

🐞 Bug report

Command (mark with an `x`)

- [ ] new
- [x] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

yes

Description

I have set "target": "es6", when i try to serve my application using below command

ng serve ---aot

It throws below error:

If i change target to "es2015" and try to run using below commands

ng serve --prod

ng serve --aot

it throws a same error.

Working fine

When using "ng serve" with target es2015 and es6

And all commands are working fine with target as es5

🔬 Minimal Reproduction

Download sample- issueSample.zip
Run "npm i"
The give anyone command from below list:

ng serve --aot
ng build --aot
ng serve --prod
ng build --prod

🔥 Exception or Error

🌍 Your Environment


"@angular-devkit/build-angular": "^0.800.2",
"@angular-devkit/build-optimizer": "^0.800.2",
"@angular/cli": "~8.0.0",
"@angular/compiler-cli": "~8.0.0",

Anything else relevant?

Reported issue occurs only when i use services in providers like below:

import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import { GridModule } from '@syncfusion/ej2-angular-grids';
// have to below service
import { PageService, SortService, FilterService, GroupService } from '@syncfusion/ej2-angular-grids';
import { AppComponent } from './app.component';
 
@NgModule({
 declarations: [
 AppComponent
 ],
 imports: [
 BrowserModule,
 GridModule
 ],
 providers: [PageService,
 SortService,
 FilterService,
 GroupService],
 bootstrap: [AppComponent]
})
export class AppModule { }

When i add service like below it doesn't throws error even service also not get injected.
#4043 (comment)

i have used above reference like below:

import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import { GridModule } from '@syncfusion/ej2-angular-grids';
import { PageService, SortService, FilterService, GroupService } from '@syncfusion/ej2-angular-grids';
import { AppComponent } from './app.component';
const providers = [];
providers.push({ PageService });
providers.push({ SortService });
providers.push({ FilterService });
providers.push({ GroupService });
@NgModule({
 declarations: [
 AppComponent
 ],
 imports: [
 BrowserModule,
 GridModule
 ],
 providers: [providers],
 bootstrap: [AppComponent]
})
export class AppModule { }

It wont throw error and also my service not injected.

@kumaresan-subramani

@kumaresan-subramani, can you please provide a link with the most possible code to get that error?

Thanks.

@alan-agius4

Hi @alan-agius4 ,

Repo steps

Please find issue reproducing steps here:

Step1: download sample -
issueSample.zip

step2: Run below commands:

npm i

ng serve --prod

You will see an error,When you set"target" to "es5" it works fine.

I think, class expression got tree-shaken away

Old Issue - #14577 (comment)

@alan-agius4

HI @alan-agius4 ,

Due to this #14577,

Description

TypeScript ClassExpression are not being treeshaken away.

Example codes:

let ChipList = class ChipList extends Component {
  constructor(options, element) {
        super(options, element);
    }
};
__decorate$4([
    Property([])
], ChipList.prototype, "chips", void 0);
ChipList = __decorate$4([
    NotifyPropertyChanges
], ChipList);

Anything else relevant?

#14263

you have added this fix . i think this causes issue now.

Thanks in advance

I think I found the problem, I will land a PR soon.

@alan-agius4

Hi @alan-agius4 ,

Could you please update when the fix will be moved to npm, which will helpful for me to proceed further.

Please add release notes, if you have made any major changes related to tree-shaking which will be helpful for me to work at my end.

Release notes are located here: https://github.com/angular/angular-cli/releases

@clydin

Thanks @clydin ,

https://github.com/angular/angular-cli/releases/tag/v8.2.2

#15303

#15301

fix(@angular-devkit/build-optimizer): don't mark tslib helpers which …

@alan-agius4

@alan-agius4 ,

is this fix got published?. if yes, please tell me @angular-devkit/build-optimizer version.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

fix(@angular-devkit/build-optimizer): don't mark tslib helpers which …

Navigation Menu

Repository navigation

Using services in providers, Build got failed while using 'ng build ---aot' #15392

🐞 Bug report

Command (mark with an `x`)

Is this a regression?

Description

Working fine

🔬 Minimal Reproduction

🔥 Exception or Error

🌍 Your Environment

Anything else relevant?

Repo steps

I think, class expression got tree-shaken away

Description

you have added this fix . i think this causes issue now.

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Using services in providers, Build got failed while using 'ng build ---aot' #15392

Description

🐞 Bug report

Command (mark with an x)

Is this a regression?

Description

Working fine

🔬 Minimal Reproduction

🔥 Exception or Error

🌍 Your Environment

Anything else relevant?

Activity

alan-agius4 commented on Aug 26, 2019

kumaresan-subramani commented on Aug 26, 2019

Repo steps

I think, class expression got tree-shaken away

kumaresan-subramani commented on Aug 27, 2019

Description

you have added this fix . i think this causes issue now.

alan-agius4 commented on Aug 27, 2019

kumaresan-subramani commented on Aug 27, 2019

clydin commented on Aug 27, 2019

kumaresan-subramani commented on Aug 27, 2019

kumaresan-subramani commented on Aug 28, 2019

angular-automatic-lock-bot commented on Sep 29, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Command (mark with an `x`)