Skip to content

fix(@angular/cli): handles not found packages for ng-update - #29358

Closed
allout58 wants to merge 1 commit into
angular:mainfrom
allout58:fix/28834/ng-update-private-packages
Closed

allout58 wants to merge 1 commit into
angular:mainfrom
allout58:fix/28834/ng-update-private-packages

Conversation

@allout58

Copy link
Copy Markdown

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #28834

What is the new behavior?

Packages in private or unknown repositories that cannot be found are skipped when trying to run ng update

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Ignore errors when trying to fetch a packages metadata from NPM.

Fixes angular#28834
@alan-agius4
alan-agius4 self-requested a review January 15, 2025 20:43
@alan-agius4 alan-agius4 linked an issue Jan 16, 2025 that may be closed by this pull request
@alan-agius4

Copy link
Copy Markdown
Collaborator

Hi @allout58, thanks for the update! Unfortunately, this fix isn't correct, as it interferes with real cases where the error needs to be propagated. In fact, some of our E2E tests are failing because of this change.

Instead of using the package name, the value should be parsed and used.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng update breaks on "private" packages

2 participants