Skip to content

chore(new): prevent generation of .gitignore when using --skip-git - #3713

Merged
hansl merged 1 commit into
angular:masterfrom
Brocco:skip-git
Dec 28, 2016
Merged

hansl merged 1 commit into
angular:masterfrom
Brocco:skip-git

Conversation

@Brocco

@Brocco Brocco commented Dec 23, 2016

Copy link
Copy Markdown
Contributor

Generating a new project when using --skip-git a .gitignore file is still created, this PR will prevent that file from being generated hence reducing app clutter.

@hansl

hansl commented Dec 28, 2016

Copy link
Copy Markdown
Contributor

LGTM, thanks!

@hansl
hansl merged commit 78ee47c into angular:master Dec 28, 2016
@Brocco
Brocco deleted the skip-git branch December 29, 2016 03:57
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@ADTC

ADTC commented Nov 26, 2017

Copy link
Copy Markdown

If this is by design, this is a very sad design decision. I hope the counterargument for creating the file as shown in #8638 makes sense. Or we can at least consider adding a --gitignore flag to create the file?

@Executus

Copy link
Copy Markdown

I agree with ADTC, there should be a flag to create the gitignore file. Anyone who uses VSTS will find this design troublesome, as git projects must be initialised in VSTS first, hence you don't want to init a git repo on the client, but still want the gitignore.

@arturhun

Copy link
Copy Markdown

It is a very bad design decision, without giving any option to work it around.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants