This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
What was the reason for this in the past? It doesn't appear to do anything
Contributor
Author
There was a problem hiding this comment.
element(by.xyz).getText() is an elementFinder/promise.
When someone enters element(by.xyz).getText(), we need to return the text value of the elementFinder (i.e. by calling then) instead of the text representation of the elementFinder.
hankduan
force-pushed
the
fixelementexplorer
branch
from
March 4, 2015 20:52
8349cdb to
6a28eb5
Compare
hankduan
force-pushed
the
fixelementexplorer
branch
from
March 5, 2015 07:56
6a28eb5 to
11fc94e
Compare
Member
|
LGTM sorry for the delay |
Contributor
Author
|
merged in 5d23280 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...functions