Skip to content

feat(app): add desktop setting to toggle file changes display - #30264

Closed
anduimagui wants to merge 2 commits into
anomalyco:devfrom
anduimagui:feat/desktop-show-file-changes
Closed

anduimagui wants to merge 2 commits into
anomalyco:devfrom
anduimagui:feat/desktop-show-file-changes

Conversation

@anduimagui

@anduimagui anduimagui commented Jun 1, 2026 •

Copy link
Copy Markdown

Issue for this PR

Closes #9089 (desktop-specific)

Type of change

  • New feature

What does this PR do?

Adds a desktop-only setting to show or hide the "Changed file +N -M" diff summary in the session timeline. This gives users a cleaner chat view when they don't want the file-change accordion taking up vertical space.

Related work:

Changes:

  • packages/app/src/context/settings.tsx — adds showFileChanges boolean to general settings (default true)
  • packages/app/src/i18n/en.ts — adds English translation keys for the new setting
  • packages/app/src/components/settings-general.tsx — adds a desktop-gated <Switch> toggle in Settings > General
  • packages/app/src/pages/session/message-timeline.tsx — wraps DiffSummary timeline rows with a reactive <Show> so they hide/show instantly when the setting changes

Why it works:
The toggle uses the existing settings.general persistence layer (already used by showReasoningSummaries, showSessionProgressBar, etc.). In the timeline, <Show when={...}> creates a SolidJS reactive subscription, so the rows update in real time without waiting for a new message or re-render.

How did you verify your code works?

  • bun typecheck in packages/app passes (pre-existing unrelated errors in stats-server/stats-core)
  • No new tests added — follows the existing settings pattern used by other boolean toggles

Screenshots / recordings

Not included.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@anduimagui
anduimagui requested a review from adamdotdevin as a code owner June 1, 2026 17:09
@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Jun 1, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@thdxr
thdxr requested review from Brendonovich and Hona as code owners June 11, 2026 00:17
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: TUI option for minimal/collapsed diff display

1 participant