Repository navigation
fix(app): only attach path-shaped @mentions in comments - #50526
Vibe-coding-nvm-delete-repo wants to merge 1 commit into
Conversation
Bare words such as @here stay inline text, so a comment mention no longer resolves to a missing workspace file. Mentions are kept only when they start with ~ or contain /, \, ., or #.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Focused changes are covered by regression tests with no unresolved review issues.
Review effort: Lite
Findings: None
What changed in this PR
Fixes comment mention parsing so only path-shaped @mentions attach files; bare words remain plain text.
Changes:
- Filter mentions to path-shaped tokens.
- Add regression coverage for bare and mixed mentions.
| File | Description |
|---|---|
packages/app/src/composer/request.ts |
Filters non-path-shaped comment mentions. |
packages/app/src/composer/request.test.ts |
Covers bare and path-shaped mention behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
Fixes #50393
A comment like
or should I use @here?attached a file namedhere, which then failed with "File not found". Every@wordin a comment was treated as a workspace path.A comment token is now a file only when it looks like one: starts with
~, or contains/,\,., or#.or should I use @here?<workspace>/here-> errorCompare with @src/shared.tssee @D:\work\a.tsRegression tests in
packages/app/src/composer/request.test.tscover the bare word and the mixed comment.Verified with bun 1.4.2:
request.test.ts17/17, composer suite 84/84, app unit suite 901/901,bun run typecheckandoxlintclean.