Repository navigation
fix: record shell mode in history (resolves #5454) - #5551
Merged
rekram1-node merged 2 commits intoDec 15, 2025
Merged
Conversation
Fixes bug 1 from issue anomalyco#5454 where shell commands were not properly recalled from message history. Previously, when typing `!date`, only the `date` text was stored in history, not the shell mode. When recalling with up arrow, this caused the command to be sent as a text message to the model instead of executed as a shell command. Changes: - Add optional `mode` field to PromptInfo type - Store current mode when appending to history - Restore mode (defaulting to 'normal' for backward compatibility) when recalling from history
The previous implementation had a timing bug where store.mode was reset to 'normal' before being saved to history. This caused all shell commands to be stored as 'normal' mode. Now we capture the mode value before the conditional branches that reset it, ensuring the correct mode is preserved in history.
ariane-emory
marked this pull request as draft
December 15, 2025 07:59
ariane-emory
marked this pull request as ready for review
December 15, 2025 08:06
nalin-singh
pushed a commit
to nalin-singh/opencode
that referenced
this pull request
Dec 17, 2025
rekram1-node
pushed a commit
that referenced
this pull request
Dec 27, 2025
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
MarsQiu007
referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
meSingh
pushed a commit
to meSingh/opencode
that referenced
this pull request
Sep 6, 2026
androidand
pushed a commit
to androidand/opencode-skein
that referenced
this pull request
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug 1 from issue #5454 where shell commands were not properly recalled from message history. Previously, when typing a shell command such as, e.g.,
!date, only thedatetext was stored in history, not the shell mode. When recalling with up arrow, this caused the command to be sent as a text message to the model instead of executed as a shell command. With this PR, the shell mode state is recorded alongside the message so that it is properly restored when cycling through the command history.Changes:
modefield to PromptInfo typeResolves #5454 (at least, the 'bug 1' part of it).