Skip to content

fix(app): size the agent menu to its options #60026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hona merged 1 commit into from
Oct 30, 2026
Merged

fix(app): size the agent menu to its options #60026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/app/src/composer/editor/editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ export function ComposerEditor(props: ComposerEditorProps) {
<Show when={view.agent} keyed>
{(control) => (
<ComposerEditorConfiguredSelect
fitMenuToOptions
title={i18n.t("ui.promptInput.chooseAgent")}
keybind={["Mod", "."]}
control={control}
Expand Down Expand Up @@ -987,6 +988,7 @@ function pointerFocusReturn() {

function ComposerEditorConfiguredSelect(props: {
mobileDrawer?: boolean
fitMenuToOptions?: boolean
title: string
keybind?: string[]
control: ComposerSelectControl
Expand All @@ -999,6 +1001,7 @@ function ComposerEditorConfiguredSelect(props: {
return (
<ComposerEditorSelect
mobileDrawer={props.mobileDrawer}
fitMenuToOptions={props.fitMenuToOptions}
title={props.title}
class={props.class}
keybind={props.control.keybind?.() ?? props.keybind}
Expand All @@ -1016,6 +1019,8 @@ function ComposerEditorConfiguredSelect(props: {

function ComposerEditorSelect(props: {
mobileDrawer?: boolean
/** Size the menu to its longest option instead of the shared 160px minimum, with room before the check. */
fitMenuToOptions?: boolean
title: string
keybind?: string[]
options: ComposerOption[]
Expand Down Expand Up @@ -1079,11 +1084,18 @@ function ComposerEditorSelect(props: {
{content()}
</Menu.Trigger>
<Menu.Portal>
<Menu.Content onCloseAutoFocus={focus.onCloseAutoFocus}>
<Menu.Content
onCloseAutoFocus={focus.onCloseAutoFocus}
class={props.fitMenuToOptions ? "!min-w-0" : undefined}
>
<Menu.RadioGroup value={props.current} onChange={props.onSelect}>
<For each={props.options}>
{(option) => (
<Menu.RadioItem value={option.id} class="capitalize" closeOnSelect>
<Menu.RadioItem
value={option.id}
class={props.fitMenuToOptions ? "capitalize !gap-6" : "capitalize"}
closeOnSelect
>
{option.label}
</Menu.RadioItem>
)}
Expand Down
Loading