Repository navigation
feat(app): align searchable dialogs - #60162
Conversation
There was a problem hiding this comment.
Looks sound. I ran the new Fork component test (3 repeated runs), the full mcp-workspace-toggle.spec.ts e2e file (13/13, including the settings-shortcut case) and tsc -b in packages/app; all pass. I also checked the new MCP, Fork and plugin stories in the browser. The dialogs fit their content, keep the search field in place while filtering and scrolling, and existing toggle, pending and fork behaviour is unchanged by the split into presentational components. The package's typecheck script (bun check --no-script -b) fails here with "Script not found: check", so I ran tsc -b instead.
Public API: unchanged (internal app components, CSS and one English i18n string only).
No blocking concerns.
There was a problem hiding this comment.
The new commit is lint cleanup only and changes no behaviour: blank lines, a lookup table in place of a nested ternary in the e2e open helper, and Predicate.isString in place of typeof checks. My earlier review raised no concerns, so there was nothing for it to address. At the new head, the Fork component test passes, all 13 cases in mcp-workspace-toggle.spec.ts pass, and tsc -b in packages/app passes.
Public API: unchanged.
No new concerns.
There was a problem hiding this comment.
This push only merges dev and leaves the pull request's own files unchanged. Comparing the head with the dev commit it merged shows only this pull request's 10 files, so the merge resolved cleanly. tsc -b in packages/app and the Fork component test still pass.
Public API: unchanged.
No new concerns.


Issue for this PR
N/A — UI alignment with the recently updated search, command, and project pickers.
Type of change
What does this PR do?
How did you verify your code works?
bun run checkand appbun typecheckpass.dev.dev; the composer-history failure does not reproduce in three focused reruns on either branch.Visual
Screenshots / recordings
Checklist