Skip to content

fix(app): match search dialog radius and background - #60200

Merged
arvsrn merged 2 commits into
devfrom
search-dialog-surfaces
Oct 29, 2026
Merged

arvsrn merged 2 commits into
devfrom
search-dialog-surfaces

Conversation

@arvsrn

@arvsrn arvsrn commented Oct 29, 2026

Copy link
Copy Markdown
Member

Search dialogs now share one surface: a 12px corner radius on bg-base.

  • Background: the compact command palette, MCP, plugin picker, fork and project search dialogs move from bg-layer-01 to bg-base. Their sticky group headers and fade drop the bg-layer-01 overrides and use the search list's default surface, which is bg-base.
  • Radius: integrations and manage models go from the 6px dialog default to 12px. The model picker and fork dialog go from 10px to 12px.

The folder picker (used on web and for remote servers) is unchanged. Its folder tree sits in a bordered bg-base box, which would blend into a bg-base dialog.

Visual

<svg xmlns="http://www.w3.org/2000/svg" width="240" height="72" viewBox="0 0 240 72" fill="none" stroke="currentColor">
  <style>
    .d { animation: r 3s ease-in-out infinite alternate; }
    .d2 { animation-delay: -1s; }
    .d3 { animation-delay: -2s; }
    @keyframes r { from { rx: 3px; ry: 3px; } to { rx: 8px; ry: 8px; } }
    @media (prefers-reduced-motion: reduce) { .d { animation: none; } }
  </style>
  <rect class="d" x="12" y="10" width="64" height="52" rx="8" fill="currentColor" fill-opacity="0.06" stroke-opacity="0.35"/>
  <rect class="d d2" x="88" y="10" width="64" height="52" rx="8" fill="currentColor" fill-opacity="0.06" stroke-opacity="0.35"/>
  <rect class="d d3" x="164" y="10" width="64" height="52" rx="8" fill="currentColor" fill-opacity="0.06" stroke-opacity="0.35"/>
  <g stroke-opacity="0.3" stroke-linecap="round">
    <line x1="20" y1="22" x2="56" y2="22"/><line x1="20" y1="34" x2="68" y2="34"/><line x1="20" y1="44" x2="60" y2="44"/>
    <line x1="96" y1="22" x2="132" y2="22"/><line x1="96" y1="34" x2="144" y2="34"/><line x1="96" y1="44" x2="136" y2="44"/>
    <line x1="172" y1="22" x2="208" y2="22"/><line x1="172" y1="34" x2="220" y2="34"/><line x1="172" y1="44" x2="212" y2="44"/>
  </g>
</svg>

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks sound from reading the code: the compact palette, MCP, plugin, fork and project search dialogs all end up on bg-base. Their sticky headers and fade now use the search list's default surface, which is bg-base. The fork dialog now gets its 12px radius from the shared .command-palette container rule. The folder picker doesn't use any of these selectors, so it is unchanged.

I couldn't run this: it's a web app change, and there's no browser in the review environment. Could you add before/after screenshots of a couple of these dialogs (e.g. the command palette with a sticky group header scrolled, and manage models)?

Public API: unchanged.

Small redundancy, not blocking: manage models already gets bg-base from the settings dialog variant, so the background line added in manage.css has no effect.

@arvsrn
arvsrn enabled auto-merge (squash) October 29, 2026 11:28

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new commits only merge dev, so the pull request's own changes are the same as in the previous review and I have nothing new to raise. Public API: unchanged. The OpenAPI update comes from dev (#60228), not from this pull request.

I still couldn't run this web app change here, so before/after screenshots of a couple of the dialogs would still help.

@arvsrn
arvsrn merged commit d9d3548 into dev Oct 29, 2026
20 checks passed
@arvsrn
arvsrn deleted the search-dialog-surfaces branch October 29, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant