Repository navigation
fix(app): match search dialog radius and background - #60200
Conversation
There was a problem hiding this comment.
The change looks sound from reading the code: the compact palette, MCP, plugin, fork and project search dialogs all end up on bg-base. Their sticky headers and fade now use the search list's default surface, which is bg-base. The fork dialog now gets its 12px radius from the shared .command-palette container rule. The folder picker doesn't use any of these selectors, so it is unchanged.
I couldn't run this: it's a web app change, and there's no browser in the review environment. Could you add before/after screenshots of a couple of these dialogs (e.g. the command palette with a sticky group header scrolled, and manage models)?
Public API: unchanged.
Small redundancy, not blocking: manage models already gets bg-base from the settings dialog variant, so the background line added in manage.css has no effect.
There was a problem hiding this comment.
The new commits only merge dev, so the pull request's own changes are the same as in the previous review and I have nothing new to raise. Public API: unchanged. The OpenAPI update comes from dev (#60228), not from this pull request.
I still couldn't run this web app change here, so before/after screenshots of a couple of the dialogs would still help.
Search dialogs now share one surface: a 12px corner radius on
bg-base.bg-layer-01tobg-base. Their sticky group headers and fade drop thebg-layer-01overrides and use the search list's default surface, which isbg-base.The folder picker (used on web and for remote servers) is unchanged. Its folder tree sits in a bordered
bg-basebox, which would blend into abg-basedialog.Visual