Repository navigation
fix(app): count queued quotes and annotations as attachments - #60235
Conversation
There was a problem hiding this comment.
Looks sound. I ran the new queuedPromptRows cases against the base queue.ts: 9 fail there (quotes and notes aren't counted, and context-only rows show the raw model-facing text). With this change all 23 queue tests pass and tsc -b in packages/app is clean. The count stays consistent with editedPromptInput: a text edit keeps the comments, and a context-only edit turns them into text and drops them. File comments aren't double-counted.
Public API: unchanged (app UI logic only).
Not blocking: the new test table has 12 cases for a ~14-line change. The malformed-metadata cases mostly test readPromptPresentation decoding rather than this change, so it could be cut down to the core cases (quote, note, context-only, mixed with a file comment, pending edit).
There was a problem hiding this comment.
The test table is now cut down to the core cases, which addresses my earlier note. The merge from dev doesn't change this PR's own diff, and the fix is the same as before. The 17 queue tests pass and tsc -b in packages/app is clean. Public API: unchanged. Nothing new to flag.
Summary
Screenshots
Before:

After:

Verification
bun run checkand appbun typecheckpass after updating to latestorigin/dev.Visual