Skip to content

fix(cli): keep loopback requests off environment proxies #60441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rekram1-node merged 2 commits into from
Oct 30, 2026
+23 −12
Merged

fix(cli): keep loopback requests off environment proxies #60441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ccd399
fix(cli): keep loopback requests off environment proxies
rekram1-node Oct 30, 2026
3cffdb7
fix(cli): satisfy changed-file lint in the no_proxy merge
rekram1-node Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/cli/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@ import { Heap } from "./heap"
import { CpuProfile } from "./cpu-profile"
import { ShutdownDeadline } from "./shutdown-deadline"

// Keep requests to the local service off any proxy. Bun reads lowercase `no_proxy` alone whenever it is set, so both
// spellings get the same merged list.
const noProxy = [
...new Set(
[process.env.NO_PROXY, process.env.no_proxy, "127.0.0.1,localhost,::1"].flatMap((value) =>
(value ?? "").split(",").flatMap((entry) => entry.trim() || []),
),
),
].join(",")

process.env.NO_PROXY = noProxy
process.env.no_proxy = noProxy

ensurePluginRuntime()

if (process.env.OPENCODE_SSH_ASKPASS_PORT) {
Expand Down
22 changes: 10 additions & 12 deletions packages/desktop/src/main/lifecycle/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,16 @@ const loadSystemCertificates = Effect.try({
catch: (error) => error,
}).pipe(Effect.catch((error) => Effect.logWarning("failed to load system certificates", { error })))

// Bun reads lowercase `no_proxy` alone whenever it is set, so both spellings get the same merged list.
function ensureLoopbackNoProxy() {
const loopback = ["127.0.0.1", "localhost", "::1"]
const noProxy = [
...new Set(
[process.env.NO_PROXY, process.env.no_proxy, "127.0.0.1,localhost,::1"].flatMap((value) =>
(value ?? "").split(",").flatMap((entry) => entry.trim() || []),
),
),
].join(",")

;["NO_PROXY", "no_proxy"].forEach((key) => {
const items = (process.env[key] ?? "")
.split(",")
.map((value) => value.trim())
.filter(Boolean)

loopback.forEach((host) => {
if (!items.some((value) => value.toLowerCase() === host)) items.push(host)
})
process.env[key] = items.join(",")
})
process.env.NO_PROXY = noProxy
process.env.no_proxy = noProxy
}
Loading