[usrnk1]

Issue for this PR

Related to #48664; extends the existing quoting workflow without closing that request.

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

• Hold Cmd/Ctrl to turn the quote popup’s existing checkmark into send. Modifier+Enter uses the composer’s alternate queue/steer delivery; ordinary Enter still adds or saves.
• Send only that quote and comment, including files mentioned in the comment. Keep unrelated composer content untouched and preserve the quote on failure.

How did you verify your code works?

• bun run check, app/UI typechecks (Bun and native), and changed-file lint.
• 948 app and 316 UI unit tests.
• Six production-build quote/terminal regressions plus the existing queue-preference keeper, using the mocked API.
• Compared the same shortcut on the base and changed versions: only the changed version submits a quote-only prompt. Reviewed matching screenshots below.

Visual

<svg xmlns="http://www.w3.org/2000/svg" width="240" height="72" viewBox="0 0 240 72" fill="none" role="img" aria-label="The quote checkmark becomes send while holding a modifier">
  <style>
    @media (prefers-reduced-motion: no-preference) {
      .quote-send-check { animation: quote-send-check 4s infinite; }
      .quote-send-arrow { animation: quote-send-arrow 4s infinite; }
      .quote-send-key { animation: quote-send-key 4s infinite; }
    }
    @keyframes quote-send-check { 0%,40%,100% { opacity:1 } 50%,90% { opacity:0 } }
    @keyframes quote-send-arrow { 0%,40%,100% { opacity:0 } 50%,90% { opacity:1 } }
    @keyframes quote-send-key { 0%,40%,100% { opacity:.4 } 50%,90% { opacity:1 } }
  </style>
  <rect x="4.5" y="4.5" width="231" height="63" rx="8" fill="currentColor" fill-opacity=".04" stroke="currentColor" stroke-opacity=".2"/>
  <path d="M15 14v14M23 17h125M23 25h84" stroke="currentColor" stroke-opacity=".3" stroke-linecap="round"/>
  <path d="M15 42h105M15 51h80" stroke="currentColor" stroke-opacity=".6" stroke-linecap="round"/>
  <g class="quote-send-key" opacity=".4">
    <rect x="139.5" y="43.5" width="59" height="17" rx="3" fill="currentColor" fill-opacity=".06" stroke="currentColor" stroke-opacity=".3"/>
    <text x="169" y="55" text-anchor="middle" font-size="9" font-family="inherit" fill="currentColor">⌘/Ctrl ↵</text>
  </g>
  <rect x="207.5" y="41.5" width="20" height="20" rx="4" fill="currentColor" fill-opacity=".1" stroke="currentColor" stroke-opacity=".3"/>
  <path class="quote-send-check" d="m212 51 4 4 7-8" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round"/>
  <path class="quote-send-arrow" opacity="0" d="M217.5 56V47m-4 4 4-4 4 4" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round"/>
</svg>

Screenshots / recordings

Same viewport, theme, draft, quote, and held modifier; before is the unmodified base.

Before:

After:

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

---

Added by the opencode bot (AI-generated).

Related: #48664

[opencodejr]

The approach looks sound. I couldn't run the popup here: the change is in the web/desktop composer, and the sandbox has no browser for the Playwright specs. The composer unit tests pass (130/0), including the new submitQuote cases, and tsc passes for packages/app and packages/ui.

Public API: unchanged. Everything here is internal app/UI component props, plus four new i18n strings.

Two points worth addressing, details inline:

• submitQuote copies the steer/optimistic-busy/background/failure handling from submit. These two copies will drift apart.
• The new e2e scenario loop is hard to follow. Each scenario branches on how it triggers the send.

Related: #48664

[opencodejr]

This block (the steer handoff, optimistic running status, background() move, and on failure the admitted check, handoff clear and status reset) repeats lines 167–211 of submit almost line for line. A shared helper for sending a normal prompt, called by both paths, would stop a future fix to one path from missing the other. Only the post-send steps (remove context vs. clear the submission) really differ.

[usrnk1]

Addressed in 14c3573. Both paths now use dispatchPrompt for handoff, optimistic status, backgrounding, and common failure/admission settlement. The callers retain their different clear/restore timing. Full check, 948 app tests, and the quote/queue browser keepers pass.

[opencodejr]

This loop is hard to follow. Each of the four scenarios takes a different path: mentioning switches between clicking and pressing a key, !working && queue picks which element gets the keypress, and the bounding-box, tooltip and mention checks only apply to some scenarios. The behaviour that matters is which delivery is sent for idle vs. working, and that the draft and other context are kept. Could you split it into one straight-line test that checks those, plus at most one separate test for the mention/read-only-while-sending behaviour? The delivery mapping itself is already covered by the unit test.

[usrnk1]

Addressed in 14c3573. Replaced the four-scenario loop with one straight-line draft/context-isolation test and one separate mention/read-only test; retry coverage remains separate. Unit cases now assert delivery(true), and I confirmed they fail with delivery(false). The existing queue-preference keeper checks the mapping. All 40 repeat runs passed.

[opencodejr]

Both earlier points are fixed. submit and submitQuote now share dispatchPrompt for the handoff, optimistic busy status, background move and failure handling. The e2e scenario loop is now two straight-line tests. I found nothing new in the update. The composer unit tests pass (130/0) and tsc passes for packages/app. The e2e type check shows 13 errors on both the base and this head, none of them in the new tests. I still couldn't run the popup here, because the sandbox has no browser.

The public API is unchanged.

[opencodejr]

The update is a merge of dev, and none of this PR's own files changed. After the merge, the composer unit tests pass (130/0) and tsc passes for packages/app and packages/ui. I have nothing new to raise. I still couldn't run the popup here, because the sandbox has no browser.

The public API is unchanged.

[opencodejr]

The update is another merge of dev, and this PR's own changes are the same as before. After the merge, the composer unit tests pass (130/0) and tsc passes for packages/app. I have nothing new to raise. I still couldn't run the popup here, because the sandbox has no browser.

The public API is unchanged.