Repository navigation
Emit metric dag auto paused - #69078
takayoshi-makabe wants to merge 3 commits into
Conversation
|
CI falling |
|
I fixed it. The commands below execute successfully. uv run python scripts/ci/prek/check_metrics_synced_with_the_registry.py airflow-core/src/airflow/models/dagrun.pyCould you please rerun the GitHub Actions? |
|
@henry3260 |
potiuk
left a comment
There was a problem hiding this comment.
Thanks — useful metric. Auto-pausing after consecutive failures is exactly the kind of thing operators want alerting on, and today it happens silently. Emitting at the point of the pause in _check_last_n_dagruns_failed is the right place, and the test asserting the stats.incr call rather than just the pause behaviour is what makes it meaningful.
One inconsistency in the metric declaration inline.
Heads-up unrelated to the change itself: #70013 also edits metrics_template.yaml, in a nearby part of the file. Whichever of the two merges second will need a trivial rebase — no action now, just so it isn't a surprise.
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
The metric was emitted in code but missing from the registry, causing the check-metrics-synced-with-registry static check to fail.
732b68f to
98128f6
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
Hi @XD-DENG @ashb @amoghrajesh, gentle ping on this PR. It has already been approved and CI is green, and it was just marked as stale. Could one of you take a look when you have a moment? I'm happy to address any feedback. |
Emit
dag.auto_pausedmetric when the scheduler automatically pauses a DAG after exceedingmax_consecutive_failed_dag_runs. Platform teams can now alert on this event directly via StatsD/OpenTelemetry without polling the database or correlating failure metrics manually.The metric includes
dag_idandrun_typetags via the existingstats_tagsproperty onDagRun.closes: #69004
Was generative AI tooling used to co-author this PR?
Claude Code
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.