Repository navigation
Conversation
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
2 times, most recently
from
August 9, 2026 15:00
40f7be8 to
26897c6
Compare
uranusjr
reviewed
Aug 9, 2026
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
2 times, most recently
from
August 11, 2026 03:37
0f18798 to
783542a
Compare
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
from
August 19, 2026 15:22
783542a to
cd2ebfe
Compare
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
from
September 4, 2026 15:34
cd2ebfe to
554e539
Compare
This was referenced Sep 25, 2026
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
2 times, most recently
from
September 28, 2026 16:33
514cb98 to
592e901
Compare
Contributor
|
I've merged everything in the chain that was blocking this; if you can get the migration rebased I can approve it and get it merged. |
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
from
October 16, 2026 04:36
0fb6db7 to
aa3a9ee
Compare
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
from
October 27, 2026 15:53
3fbff66 to
e6f19e2
Compare
uranusjr
reviewed
Nov 11, 2026
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
from
November 11, 2026 16:17
e6f19e2 to
efdf231
Compare
uranusjr
approved these changes
Nov 12, 2026
uranusjr
left a comment
Member
There was a problem hiding this comment.
PR description needs to be updated to mention the airflow db clean change.
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
from
November 12, 2026 06:38
efdf231 to
6aa6d2b
Compare
Contributor
Author
|
@uranusjr |
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
from
November 16, 2026 15:10
6aa6d2b to
98a046b
Compare
fat-catTW
force-pushed
the
callback-dagrun-fkey
branch
from
November 18, 2026 12:38
98a046b to
4fcbcf8
Compare
jason810496
reviewed
Nov 19, 2026
jason810496
left a comment
Member
There was a problem hiding this comment.
Thanks for the update, here're some comments that make sense to me from the agentic review.
ephraimbuddy
left a comment
Contributor
There was a problem hiding this comment.
Please see the three inline comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Executor callbacks need to know which DagRun they belong to when the scheduler builds callback workloads. Keeping that reference only in
callback.datamakes the scheduler depend on payload shape instead of a database-managed relationship.Solution
Add a nullable
callback.dagrun_idforeign key todag_run.idand have executor callbacks store their DagRun reference there. The scheduler now loads the relationship through the ORM when enqueueing callback workloads.The migration backfills existing rows from deadline relationships first, then falls back to legacy callback payload data when needed. Its upgrade and downgrade paths share the callback-payload deserialization logic.
To preserve archive behavior for
airflow db clean -t dag_run, addcallbackto DagRun's dependent tables. Callback rows are then archived before their DagRun is deleted, rather than being removed by the foreign-key cascade.Was generative AI tooling used to co-author this PR?
Generated-by: [Codex] following the guidelines