Repository navigation
Fix SageMaker Unified Studio trigger hook config - #72453
Merged
vincbeck merged 2 commits intoSep 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Just one nit. Approved pending green CI.
I would add the issue number to the PR description as well i.e. #72279
jroachgolf84
approved these changes
Sep 2, 2026
Contributor
Author
|
The review feedback has been addressed in efb4e00, and both targeted test suites pass locally. Could a maintainer please approve the three pending CI workflows? Thank you! |
Contributor
could you tag the maintainer or maintainers sponsoring the contributor workshop? |
vincbeck
approved these changes
Sep 4, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
2 tasks done
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forward
region_name,verify, andbotocore_configfromSageMakerUnifiedStudioNotebookOperatortoSageMakerUnifiedStudioNotebookTriggerwhen execution is deferred.Previously, these AWS hook configuration values were not forwarded to the
trigger. As a result, the triggerer could construct its hook using different
AWS configuration from the operator that originally started the notebook run,
including potentially polling a different AWS region.
This change ensures that the deferred trigger receives and serializes the same
AWS hook configuration used by the operator.
Closes #72279
Tests
Extended the deferrable operator unit test to verify that:
region_namesurvives trigger serialization.verifysurvives trigger serialization.botocore_configsurvives trigger serialization.waiter_max_attemptsbehavior remains unchanged.Tested locally with: