Skip to content

Fix SageMaker Unified Studio trigger hook config - #72453

Merged
vincbeck merged 2 commits into
apache:mainfrom
weiyu1029:fix-sagemaker-unified-studio-trigger-config
Sep 4, 2026
Merged

vincbeck merged 2 commits into
apache:mainfrom
weiyu1029:fix-sagemaker-unified-studio-trigger-config

Conversation

@weiyu1029

@weiyu1029 weiyu1029 commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

Forward region_name, verify, and botocore_config from
SageMakerUnifiedStudioNotebookOperator to
SageMakerUnifiedStudioNotebookTrigger when execution is deferred.

Previously, these AWS hook configuration values were not forwarded to the
trigger. As a result, the triggerer could construct its hook using different
AWS configuration from the operator that originally started the notebook run,
including potentially polling a different AWS region.

This change ensures that the deferred trigger receives and serializes the same
AWS hook configuration used by the operator.

Closes #72279

Tests

Extended the deferrable operator unit test to verify that:

  • region_name survives trigger serialization.
  • verify survives trigger serialization.
  • botocore_config survives trigger serialization.
  • The derived waiter_max_attempts behavior remains unchanged.

Tested locally with:

breeze testing providers-tests providers/amazon/tests/unit/amazon/aws/operators/test_sagemaker_unified_studio_notebook.py

breeze testing providers-tests providers/amazon/tests/unit/amazon/aws/triggers/test_sagemaker_unified_studio_notebook.py

---

##### Was generative AI tooling used to co-author this PR?

<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->

- [X] Yes (please specify the tool below)
<!-- Generated-by: ChatGPT following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->

---

* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.

@weiyu1029
weiyu1029 requested a review from o-nikolas as a code owner September 2, 2026 18:21

@SameerMesiah97 SameerMesiah97 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit. Approved pending green CI.

I would add the issue number to the PR description as well i.e. #72279

@weiyu1029

Copy link
Copy Markdown
Contributor Author

The review feedback has been addressed in efb4e00, and both targeted test suites pass locally. Could a maintainer please approve the three pending CI workflows? Thank you!

@SameerMesiah97

Copy link
Copy Markdown
Contributor

The review feedback has been addressed in efb4e00, and both targeted test suites pass locally. Could a maintainer please approve the three pending CI workflows? Thank you!

@jroachgolf84

could you tag the maintainer or maintainers sponsoring the contributor workshop?

@ColtenOuO ColtenOuO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great work!

@eladkal
eladkal requested a review from vincbeck September 3, 2026 22:14
@vincbeck
vincbeck merged commit 760ee9a into apache:main Sep 4, 2026
83 checks passed
@boring-cyborg

boring-cyborg Bot commented Sep 4, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forward hook config to the SageMakerUnifiedStudioNotebookTrigger

5 participants