Skip to content

Add missing Amazon utility tests - #72985

Merged
vincbeck merged 1 commit into
apache:mainfrom
fat-catTW:fix-amazon-overlooked-utils-tests
Sep 14, 2026
Merged

vincbeck merged 1 commit into
apache:mainfrom
fat-catTW:fix-amazon-overlooked-utils-tests

Conversation

@fat-catTW

@fat-catTW fat-catTW commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This closes three Amazon provider module coverage gaps:

  • providers/amazon/tests/unit/amazon/aws/triggers/test_sagemaker_unified_studio.py
    • Renames the existing test file from test_sagemaker_unified_studio_trigger.py so it matches the provider module coverage convention.
  • providers/amazon/tests/unit/amazon/aws/utils/test_sagemaker.py
    • Adds dedicated enum coverage for ApprovalStatus.
  • providers/amazon/tests/unit/amazon/aws/utils/test_rds.py
    • Adds dedicated enum coverage for RdsDbType.

The newly covered files are removed from OVERLOOKED_TESTS.

Tests:

  • uv run ruff format providers/amazon/tests/unit/amazon/aws/utils/test_sagemaker.py providers/amazon/tests/unit/amazon/aws/utils/test_rds.py airflow-core/tests/unit/always/test_project_structure.py providers/amazon/tests/unit/amazon/aws/triggers/test_sagemaker_unified_studio.py
  • uv run ruff check --fix providers/amazon/tests/unit/amazon/aws/utils/test_sagemaker.py providers/amazon/tests/unit/amazon/aws/utils/test_rds.py airflow-core/tests/unit/always/test_project_structure.py providers/amazon/tests/unit/amazon/aws/triggers/test_sagemaker_unified_studio.py
  • breeze run --skip-image-upgrade-check pytest providers/amazon/tests/unit/amazon/aws/triggers/test_sagemaker_unified_studio.py providers/amazon/tests/unit/amazon/aws/utils/test_sagemaker.py providers/amazon/tests/unit/amazon/aws/utils/test_rds.py airflow-core/tests/unit/always/test_project_structure.py -xvs
Was generative AI tooling used to co-author this PR?
  • [X] Yes (please specify the tool below)

Generated-by: [Codex] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Sep 11, 2026
@fat-catTW
fat-catTW force-pushed the fix-amazon-overlooked-utils-tests branch from 60db7db to 183fc88 Compare September 11, 2026 16:46
@vincbeck
vincbeck merged commit bbe3991 into apache:main Sep 14, 2026
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants