Skip to content

Sync Dag permissions for CustomAuthManager - #74022

Merged
vincbeck merged 2 commits into
apache:mainfrom
boschglobal:feature/patch-pem-sync-for-inherited-fabauthmanager
Oct 9, 2026
Merged

vincbeck merged 2 commits into
apache:mainfrom
boschglobal:feature/patch-pem-sync-for-inherited-fabauthmanager

Conversation

@AutomationDev85

@AutomationDev85 AutomationDev85 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Overview

We faced the issue that the DAG permission are not sync when using a subclass (CustomAuthManager) of the FabAuthManager because
Dag permission syncing currently checks the auth manager's name, so subclasses of FabAuthManager can be missed. This change checks the configured class instead.

Details of change:

  • Sync Dag permissions for FAB subclasses and cache the optional FAB class lookup.
  • Add a regression test for subclass detection and the cached lookup.
Was generative AI tooling used to co-author this PR?
  • Yes — GitHub Copilot

Generated-by: GitHub Copilot following the guidelines

@AutomationDev85
AutomationDev85 force-pushed the feature/patch-pem-sync-for-inherited-fabauthmanager branch from 6a1738a to 0ea5512 Compare October 1, 2026 12:26
@AutomationDev85 AutomationDev85 changed the title Sync Dag permissions for FabAuthManager subclasses Sync Dag permissions for CustomAuthManager Oct 2, 2026
@AutomationDev85
AutomationDev85 force-pushed the feature/patch-pem-sync-for-inherited-fabauthmanager branch from 679c730 to c5d14e6 Compare October 9, 2026 14:37

@vincbeck vincbeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner :)

@vincbeck
vincbeck merged commit aef8813 into apache:main Oct 9, 2026
85 checks passed
@jscheffl

Copy link
Copy Markdown
Contributor

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants