Repository navigation
Add name filtering to the Deadline Alerts API - #74127
Merged
Merged
Conversation
SameerMesiah97
force-pushed
the
DeadlineAlerts-Name-Filter
branch
2 times, most recently
from
October 3, 2026 18:59
cb62819 to
b276ad9
Compare
SameerMesiah97
marked this pull request as ready for review
October 3, 2026 20:14
SameerMesiah97
requested review from
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
henry3260,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 3, 2026 20:14
fat-catTW
reviewed
Oct 4, 2026
SameerMesiah97
force-pushed
the
DeadlineAlerts-Name-Filter
branch
from
October 5, 2026 18:17
b276ad9 to
1c226ab
Compare
SameerMesiah97
marked this pull request as draft
October 18, 2026 12:59
SameerMesiah97
force-pushed
the
DeadlineAlerts-Name-Filter
branch
from
October 18, 2026 13:11
1c226ab to
b983af9
Compare
SameerMesiah97
marked this pull request as ready for review
October 18, 2026 13:11
ferruzzi
reviewed
Oct 20, 2026
added 2 commits
October 24, 2026 19:30
Allow Deadline Alerts to be filtered by name using the existing FilterParam infrastructure and add API tests covering matching, non-matching, and version-scoped filtering.
Replace exact name filtering with Airflow's shared search parameter helper. Support pattern-based searches on DeadlineAlert names in the UI API. Update filtering tests and endpoint documentation.
SameerMesiah97
force-pushed
the
DeadlineAlerts-Name-Filter
branch
from
October 24, 2026 19:01
b983af9 to
79a9f11
Compare
Contributor
Author
|
Can someone trigger CI? |
shahar1
approved these changes
Oct 29, 2026
shahar1
left a comment
Contributor
There was a problem hiding this comment.
Swaps exact-name filtering for the shared search_param_factory (ILIKE substring) on the UI Deadline Alerts endpoint, addressing ferruzzi's consistency comment; tests cover single, substring, multi, no-match and version-scoped cases. One nit below, not blocking.
Smaller observations
- See inline comments on
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/deadlines.py:189.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Airflow maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Airflow handles maintainer review:
Contributing guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for filtering Deadline Alerts by name in the
GET /dags/{dag_id}/deadlineAlertsendpoint.The implementation uses the existing
FilterParaminfrastructure, allowing clients to retrieve Deadline Alerts by their configured name while remaining consistent with the filtering behaviour used across the rest of the FastAPI UI API.Rationale
The Deadline Alerts endpoint currently always returns every configured alert for a DAG. Adding support for filtering by name allows clients to request only the alerts they are interested in, rather than retrieving the full collection and filtering client-side.
This follows the existing filtering pattern used throughout the FastAPI UI API and provides a straightforward building block for UI features such as searching Deadline Alerts by name.
Tests
Added API tests verifying that:
version_numberfiltering.Backwards Compatibility
This change is fully backwards compatible. Requests that do not specify the
namequery parameter continue to return all Deadline Alerts for the requested DAG.Was generative AI tooling used to co-author this PR?
Generated-by: [GPT 5.6] following the guidelines