Repository navigation
[v3-4-test] UI: Add Select Recent Configurations dropdown to Trigger Dag form (#70413) - #74977
Merged
Merged
Conversation
…Dag form (#70413) * UI: Add Select Recent Configurations dropdown to Trigger Dag form Reusing a past run's config currently requires leaving the trigger flow to hunt for the right run in the run list and use "Trigger again with this config". Restoring the Airflow 2 in-form dropdown lets users pick any distinct config from the recent runs in a scrollable list while composing a run. The dropdown reuses the existing dagRuns list endpoint and the same conf-only prefill path as the menu item, so no new API surface is added. closes: #69820 * UI: Regroup imports in RecentConfigSelect after rebase Main now separates React imports from third-party ones, and prettier flags the file otherwise. * UI: Keep user input when selecting a recent configuration Picking a recent configuration reused the re-trigger prefill path, which resets the whole form. A user who had already set a logical date, run id, note or manual data interval lost all of them. The dropdown is meant to swap only the run's conf, so it now leaves every other field untouched. * UI: Hide recent configurations when re-triggering with a run's config "Trigger again with this config" already fills the form with one specific run's conf, so showing an unselected recent-configurations dropdown on top of it is contradictory. * UI: Use system Select for the recent configurations dropdown The dropdown rendered inside the Trigger Dag modal was clipped at the modal edge because its content stayed inside the modal's DOM tree. The shared Select from src/system-components portals its content and already renders the control, indicator and positioner, so the hand-rolled Chakra parts only duplicated those layers. The trigger form tests also follow main, where the i18n mock returns keys and TriggerDAGForm no longer takes dagDisplayName. (cherry picked from commit 6fc06c6) Co-authored-by: Wilson Josix Wang <josixwang@gmail.com>
1 task done
vatsrahul1001
marked this pull request as ready for review
October 18, 2026 09:02
vatsrahul1001
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 18, 2026 09:02
vatsrahul1001
approved these changes
Oct 18, 2026
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
…Dag form (#70413) (#74977) * UI: Add Select Recent Configurations dropdown to Trigger Dag form Reusing a past run's config currently requires leaving the trigger flow to hunt for the right run in the run list and use "Trigger again with this config". Restoring the Airflow 2 in-form dropdown lets users pick any distinct config from the recent runs in a scrollable list while composing a run. The dropdown reuses the existing dagRuns list endpoint and the same conf-only prefill path as the menu item, so no new API surface is added. closes: #69820 * UI: Regroup imports in RecentConfigSelect after rebase Main now separates React imports from third-party ones, and prettier flags the file otherwise. * UI: Keep user input when selecting a recent configuration Picking a recent configuration reused the re-trigger prefill path, which resets the whole form. A user who had already set a logical date, run id, note or manual data interval lost all of them. The dropdown is meant to swap only the run's conf, so it now leaves every other field untouched. * UI: Hide recent configurations when re-triggering with a run's config "Trigger again with this config" already fills the form with one specific run's conf, so showing an unselected recent-configurations dropdown on top of it is contradictory. * UI: Use system Select for the recent configurations dropdown The dropdown rendered inside the Trigger Dag modal was clipped at the modal edge because its content stayed inside the modal's DOM tree. The shared Select from src/system-components portals its content and already renders the control, indicator and positioner, so the hand-rolled Chakra parts only duplicated those layers. The trigger form tests also follow main, where the i18n mock returns keys and TriggerDAGForm no longer takes dagDisplayName. (cherry picked from commit 6fc06c6) Co-authored-by: Wilson Josix Wang <josixwang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing a past run's config currently requires leaving the trigger flow
to hunt for the right run in the run list and use "Trigger again with
this config". Restoring the Airflow 2 in-form dropdown lets users pick
any distinct config from the recent runs in a scrollable list while
composing a run. The dropdown reuses the existing dagRuns list endpoint
and the same conf-only prefill path as the menu item, so no new API
surface is added.
closes: #69820
Main now separates React imports from third-party ones, and prettier
flags the file otherwise.
Picking a recent configuration reused the re-trigger prefill path, which
resets the whole form. A user who had already set a logical date, run id,
note or manual data interval lost all of them. The dropdown is meant to
swap only the run's conf, so it now leaves every other field untouched.
"Trigger again with this config" already fills the form with one specific
run's conf, so showing an unselected recent-configurations dropdown on top
of it is contradictory.
The dropdown rendered inside the Trigger Dag modal was clipped at the
modal edge because its content stayed inside the modal's DOM tree. The
shared Select from src/system-components portals its content and already
renders the control, indicator and positioner, so the hand-rolled Chakra
parts only duplicated those layers.
The trigger form tests also follow main, where the i18n mock returns
keys and TriggerDAGForm no longer takes dagDisplayName.
(cherry picked from commit 6fc06c6)
Co-authored-by: Wilson Josix Wang josixwang@gmail.com