Skip to content

[v3-4-test] UI: Add Select Recent Configurations dropdown to Trigger Dag form (#70413) - #74977

Merged
vatsrahul1001 merged 1 commit into
v3-4-testfrom
backport-6fc06c6-v3-4-test
Oct 18, 2026
Merged

vatsrahul1001 merged 1 commit into
v3-4-testfrom
backport-6fc06c6-v3-4-test

Conversation

@github-actions

Copy link
Copy Markdown
Contributor
  • UI: Add Select Recent Configurations dropdown to Trigger Dag form

Reusing a past run's config currently requires leaving the trigger flow
to hunt for the right run in the run list and use "Trigger again with
this config". Restoring the Airflow 2 in-form dropdown lets users pick
any distinct config from the recent runs in a scrollable list while
composing a run. The dropdown reuses the existing dagRuns list endpoint
and the same conf-only prefill path as the menu item, so no new API
surface is added.

closes: #69820

  • UI: Regroup imports in RecentConfigSelect after rebase

Main now separates React imports from third-party ones, and prettier
flags the file otherwise.

  • UI: Keep user input when selecting a recent configuration

Picking a recent configuration reused the re-trigger prefill path, which
resets the whole form. A user who had already set a logical date, run id,
note or manual data interval lost all of them. The dropdown is meant to
swap only the run's conf, so it now leaves every other field untouched.

  • UI: Hide recent configurations when re-triggering with a run's config

"Trigger again with this config" already fills the form with one specific
run's conf, so showing an unselected recent-configurations dropdown on top
of it is contradictory.

  • UI: Use system Select for the recent configurations dropdown

The dropdown rendered inside the Trigger Dag modal was clipped at the
modal edge because its content stayed inside the modal's DOM tree. The
shared Select from src/system-components portals its content and already
renders the control, indicator and positioner, so the hand-rolled Chakra
parts only duplicated those layers.

The trigger form tests also follow main, where the i18n mock returns
keys and TriggerDAGForm no longer takes dagDisplayName.
(cherry picked from commit 6fc06c6)

Co-authored-by: Wilson Josix Wang josixwang@gmail.com

…Dag form (#70413)

* UI: Add Select Recent Configurations dropdown to Trigger Dag form

Reusing a past run's config currently requires leaving the trigger flow
to hunt for the right run in the run list and use "Trigger again with
this config". Restoring the Airflow 2 in-form dropdown lets users pick
any distinct config from the recent runs in a scrollable list while
composing a run. The dropdown reuses the existing dagRuns list endpoint
and the same conf-only prefill path as the menu item, so no new API
surface is added.

closes: #69820

* UI: Regroup imports in RecentConfigSelect after rebase

Main now separates React imports from third-party ones, and prettier
flags the file otherwise.

* UI: Keep user input when selecting a recent configuration

Picking a recent configuration reused the re-trigger prefill path, which
resets the whole form. A user who had already set a logical date, run id,
note or manual data interval lost all of them. The dropdown is meant to
swap only the run's conf, so it now leaves every other field untouched.

* UI: Hide recent configurations when re-triggering with a run's config

"Trigger again with this config" already fills the form with one specific
run's conf, so showing an unselected recent-configurations dropdown on top
of it is contradictory.

* UI: Use system Select for the recent configurations dropdown

The dropdown rendered inside the Trigger Dag modal was clipped at the
modal edge because its content stayed inside the modal's DOM tree. The
shared Select from src/system-components portals its content and already
renders the control, indicator and positioner, so the hand-rolled Chakra
parts only duplicated those layers.

The trigger form tests also follow main, where the i18n mock returns
keys and TriggerDAGForm no longer takes dagDisplayName.
(cherry picked from commit 6fc06c6)

Co-authored-by: Wilson Josix Wang <josixwang@gmail.com>
@vatsrahul1001 vatsrahul1001 added this to the Airflow 3.4.0 milestone Oct 18, 2026
@vatsrahul1001
vatsrahul1001 merged commit bcdf793 into v3-4-test Oct 18, 2026
174 of 185 checks passed
@vatsrahul1001
vatsrahul1001 deleted the backport-6fc06c6-v3-4-test branch October 18, 2026 10:15
vatsrahul1001 pushed a commit that referenced this pull request Oct 20, 2026
…Dag form (#70413) (#74977)

* UI: Add Select Recent Configurations dropdown to Trigger Dag form

Reusing a past run's config currently requires leaving the trigger flow
to hunt for the right run in the run list and use "Trigger again with
this config". Restoring the Airflow 2 in-form dropdown lets users pick
any distinct config from the recent runs in a scrollable list while
composing a run. The dropdown reuses the existing dagRuns list endpoint
and the same conf-only prefill path as the menu item, so no new API
surface is added.

closes: #69820

* UI: Regroup imports in RecentConfigSelect after rebase

Main now separates React imports from third-party ones, and prettier
flags the file otherwise.

* UI: Keep user input when selecting a recent configuration

Picking a recent configuration reused the re-trigger prefill path, which
resets the whole form. A user who had already set a logical date, run id,
note or manual data interval lost all of them. The dropdown is meant to
swap only the run's conf, so it now leaves every other field untouched.

* UI: Hide recent configurations when re-triggering with a run's config

"Trigger again with this config" already fills the form with one specific
run's conf, so showing an unselected recent-configurations dropdown on top
of it is contradictory.

* UI: Use system Select for the recent configurations dropdown

The dropdown rendered inside the Trigger Dag modal was clipped at the
modal edge because its content stayed inside the modal's DOM tree. The
shared Select from src/system-components portals its content and already
renders the control, indicator and positioner, so the hand-rolled Chakra
parts only duplicated those layers.

The trigger form tests also follow main, where the i18n mock returns
keys and TriggerDAGForm no longer takes dagDisplayName.
(cherry picked from commit 6fc06c6)

Co-authored-by: Wilson Josix Wang <josixwang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. translation:default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants