Repository navigation
[v3-4-test] Mask registered secrets at any nesting depth (#73793) - #75112
Merged
Merged
Conversation
* Mask registered secrets at any nesting depth Pattern-based masking of registered secrets stopped at max_depth: a string nested deeper than that was returned without the replacer being applied, while key-name masking already worked at any depth. Apply the replacer to string leaves wherever they sit. max_depth still bounds the fail-closed walk of a value already known to be sensitive. Generated-by: Claude Opus 5 * Add newsfragment (cherry picked from commit bfa2390) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Generated-by: Claude Opus 5
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
…5112) * Mask registered secrets at any nesting depth Pattern-based masking of registered secrets stopped at max_depth: a string nested deeper than that was returned without the replacer being applied, while key-name masking already worked at any depth. Apply the replacer to string leaves wherever they sit. max_depth still bounds the fail-closed walk of a value already known to be sensitive. Generated-by: Claude Opus 5 * Add newsfragment (cherry picked from commit bfa2390) Generated-by: Claude Opus 5 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pattern-based masking of registered secrets stopped at max_depth: a
string nested deeper than that was returned without the replacer being
applied, while key-name masking already worked at any depth. Apply the
replacer to string leaves wherever they sit. max_depth still bounds the
fail-closed walk of a value already known to be sensitive.
Generated-by: Claude Opus 5
(cherry picked from commit bfa2390)
Co-authored-by: Jarek Potiuk jarek@potiuk.com
Generated-by: Claude Opus 5