Repository navigation
Update the Go SDK doc for schema hooks that now run on every commit - #76144
Merged
Merged
Conversation
sync-go-sdk-schemas stopped being manual in apache#74091, so the doc no longer describes what a contributor meets. It still says nothing announces a stale vendored copy, which is the problem that PR fixed, and its two refresh commands pass --hook-stage manual, which no longer selects the hook.
henry3260
requested review from
amoghrajesh,
ashb and
jason810496
as code owners
October 31, 2026 14:47
shahar1
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
go-sdk/DEVELOPMENT.mddescribes how the vendored schema copies undergo-sdk/schema/stay in step with the Python distributions that own them. That account went stale whensync-go-sdk-schemasstopped being a manual hook and gained the Python schema sources as triggers, so the doc now tells a contributor the opposite of what they meet:sync-go-sdk-schemasis a manual hook and that, as a result, "nothing announces on its own that a copy has gone stale" — which is precisely the gap that change closed. A reader planning around a stale copy going unnoticed plans around a problem that no longer exists.--hook-stage manual, which no longer selects a hook that runs at thepre-commitstage.What
go-sdk/DEVELOPMENT.mdonly; no code or hook changes.mainand still land there in a combination that does not hold, which is why both hooks should be run over the whole tree before tagging.--hook-stage manualdropped, plus a note that a commit touching the task-sdk snapshot runs the hook for you, so the manual invocation is for a go-sdk maintainer moving the SDK forward deliberately rather than the only way it happens.related: #74047, #74091
Was generative AI tooling used to co-author this PR?