Repository navigation
Conversation
…ndoning a job The polling loop only treated PENDING/RUNNING/SUBMITTED as executing, so a single UNKNOWN - including on the first post-submit status query - exited the loop into the 'unexpected terminal status' path: the job was untracked despite its persisted identifier, hasAliveTableProcess stopped gating, and the next tick could submit a concurrent job for the same table. One read timeout, network blip or a new server-side status enum was enough. Keep polling while UNKNOWN within a budget (MAX_UNKNOWN_STATUS_POLLS=3, counter reset on any known status), and on exceeding it cancel the job best-effort and record a synthesized FAILED terminal state so the normal COMPLETE_FAILED path (and retry) applies. Red tests (with a compile shim on the old code): transient case stuck at SUBMITTED instead of SUCCESS; persistent case never cancelled and never FAILED. Complements the unpersisted-identifier fix. Fix record: docs/fix-records/2026-08-16-fix-21-unknown-status-tolerance.md
czy006
force-pushed
the
codex/hotfix-process-unknown-status
branch
from
August 18, 2026 02:16
ca8a26c to
42ad935
Compare
czy006
marked this pull request as ready for review
August 18, 2026 06:35
Contributor
|
@czy006 Some Checkstyle issues need to be fixed. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief change log
Continue polling after transient
UNKNOWNexecution-engine statuses and fail only after the configured consecutive threshold. On persistent unknown status, the executor performs best-effort cancellation and records the failure.How was this patch tested?
TestTableProcessExecutorlocally with JDK 11 before creating this pull request.Documentation