Repository navigation
[AMORO-4420][Hive] Preserve raw Hive partition values when building Iceberg data - #4422
Open
hutiefang76 wants to merge 1 commit into
Open
hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fixes #4420.
Raw Hive partition values can contain
/,%and+. Converting them through a generated partition path confuses value data with path separators and can break metadata synchronization or upgrades.Brief change log
PartitionDatadirectly from each raw value using Iceberg's type conversion.How was this patch tested?
JDK 17: all 5
TestHivePartitionUtiltests passed../mvnw -pl amoro-format-mixed/amoro-mixed-hive -am -Pskip-dashboard-build -Dtest=TestHivePartitionUtil -Dsurefire.failIfNoSpecifiedTests=false testdev/reformatpassed. These are conversion/key-lookup tests; no external Hive metastore or full table-upgrade integration run is claimed.Documentation
AI assistance: DeepSeek and Codex assisted implementation, tests and this description.