[C++][FS][Azure] Implement DeleteFile() #38703

Activity

1. kou

   added

   Type: enhancement

   on Nov 14, 2023
2. github-actions

   added

   Component: C++

   on Nov 14, 2023
3. av8or1 commented on Dec 4, 2023

   

   av8or1

   on Dec 4, 2023

   Contributor

   More actions

   Take

   👍React with 👍1Reacted by Felipe Oliveira Carvalho
4. github-actions

   assigned

   av8or1

   on Dec 4, 2023
5. av8or1 commented on Jan 8, 2024

   

   av8or1

   on Jan 8, 2024

   Contributor

   More actions

   Tom, I have an initial implementation completed. However, I have concerns surrounding testing. Specifically:

   1. How have other contributors been testing similar functionality?
   2. Is there a scripted process that I can follow to replicate that testing?
   3. I took a look at the azurefs_test.cc file and noted the modifications made to provide regression for similar functionality. However I am wondering what all use cases I would need to support for DeleteFile? I am not as familiar with this type of testing, as we do our own in-house stuff, but this seems straightforward enough.

   Finally, I implemented this using DeleteIfExists() rather than Delete(), for I saw that the former method was used elsewhere in the Azure work. Any feedback regarding that choice?
6. kou commented on Jan 10, 2024

   

   kou

   on Jan 10, 2024

   Last edited by kou

   MemberAuthor

   More actions

   Tom, I have an initial implementation completed. However, I have concerns surrounding testing. Specifically:

   Great! Could you open a draft PR for it?

   1. How have other contributors been testing similar functionality?

   I'm using ninja -C cpp.build debug/arrow-azurefs-test && LD_LIBRARY_PATH=$PWD/cpp.build/debug cpp.build/debug/arrow-azurefs-test. Here are some notes for the command line:

   • I'm on Debian GNU/Linux
   • I use cpp.build as my build directory for cpp/
   • The current directory is the top directory of cloned apache/arrow

   2. Is there a scripted process that I can follow to replicate that testing?

   https://arrow.apache.org/docs/developers/cpp/development.html#running-unit-tests is the standard process but it runs all tests.

   3. I took a look at the azurefs_test.cc file and noted the modifications made to provide regression for similar functionality. However I am wondering what all use cases I would need to support for DeleteFile? I am not as familiar with this type of testing, as we do our own in-house stuff, but this seems straightforward enough.

   We can borrow test patterns from GCS's one for now: https://github.com/apache/arrow/blob/main/cpp/src/arrow/filesystem/gcsfs_test.cc

   We'll use generic tests eventually after we implement all features: #39069

   Finally, I implemented this using DeleteIfExists() rather than Delete(), for I saw that the former method was used elsewhere in the Azure work. Any feedback regarding that choice?

   Let's discuss this on a draft PR.
7. av8or1 commented on Jan 17, 2024

   

   av8or1

   on Jan 17, 2024

   Last edited by kou

   Contributor

   More actions

   Thanks. I have opened a PR:
   #39648

   Note that this is my first attempt at the process of contributing to the Arrow library.
8. kou

   closed this as completedin #39840on Feb 8, 2024
9. kou

   added a commit that references this issue on Feb 8, 2024

   GH-38703: [C++][FS][Azure] Implement DeleteFile() (#39840)

   ...

   fa26fa5
10. kou

    added this to the 16.0.0 milestone on Feb 8, 2024
11. dgreiss

    added a commit that references this issue on Feb 19, 2024

    apacheGH-38703: [C++][FS][Azure] Implement DeleteFile() (apache#39840)

    ...

    75f0a72