Repository navigation
GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON - #34350
Merged
Merged
Conversation
Member
|
It seems that we also need to care about Apache Arrow Flight related examples: diff --git a/cpp/examples/arrow/CMakeLists.txt b/cpp/examples/arrow/CMakeLists.txt
index aa33c18e76..76c176086a 100644
--- a/cpp/examples/arrow/CMakeLists.txt
+++ b/cpp/examples/arrow/CMakeLists.txt
@@ -34,7 +40,7 @@ endif()
if(ARROW_FLIGHT)
# Static gRPC means we cannot linked to shared Arrow, since then
# we'll violate ODR for gRPC symbols
- if(ARROW_GRPC_USE_SHARED)
+ if(ARROW_BUILD_SHARED AND ARROW_GRPC_USE_SHARED)
set(FLIGHT_EXAMPLES_LINK_LIBS arrow_flight_shared)
if(APPLE)
set(GRPC_REFLECTION_LINK_LIBS gRPC::grpc++_reflection)
@@ -100,7 +106,7 @@ if(ARROW_FLIGHT)
"${CMAKE_CURRENT_BINARY_DIR}/helloworld.grpc.pb.cc")
if(ARROW_FLIGHT_SQL)
- if(ARROW_GRPC_USE_SHARED)
+ if(ARROW_BUILD_SHARED AND ARROW_GRPC_USE_SHARED)
set(FLIGHT_SQL_EXAMPLES_LINK_LIBS arrow_flight_sql_shared)
else()
set(FLIGHT_SQL_EXAMPLES_LINK_LIBS arrow_flight_sql_static)Could you install gRPC and try |
Contributor
Author
|
Thanks for your comment. |
Contributor
Author
|
@kou As for Flight, if |
Member
|
Yes. |
…W_BUILD_EXAMPLES=ON Signed-off-by: abetomo <abe@enzou.tokyo>
Contributor
Author
|
I could reproduce the error. If I just added |
…_SHARED=OFF Signed-off-by: abetomo <abe@enzou.tokyo>
abetomo
force-pushed
the
fix-cpp-build-error
branch
from
March 12, 2023 23:33
7e66ec5 to
d9fa805
Compare
Contributor
Author
|
The build was successful with the #34350 (comment) patch. |
Member
|
@github-actions crossbow submit example |
|
Revision: d9fa805 Submitted crossbow builds: ursacomputing/crossbow @ actions-46b0d97237
|
|
Benchmark runs are scheduled for baseline = 5b2fbad and contender = 29ec779. 29ec779 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Building with
ARROW_BUILD_SHARED=OFFandARROW_BUILD_EXAMPLES=ONcauses an error.What changes are included in this PR?
At
examples/arrow/CMakeLists.txt, setarrow_substrait_[shared|static]andgandiva_[shared|static]appropriately according toARROW_BUILD_SHARED.Are these changes tested?
In
--preset ninja-debug-maximal,ARROW_BUILD_EXAMPLES=ON.Build was completed.
Build was completed.
Are there any user-facing changes?