Repository navigation
Conversation
…st utils apache_beam.ml.rag.utils.parse_chunk_strings turned printed Chunks back into objects with eval() and an empty __builtins__. That restriction does not stop attribute access such as ().__class__.__base__, so a caller that passed it untrusted strings could run arbitrary code. Its only caller is the Milvus enrichment example test. Remove the function from utils.py and add a replacement to apache_beam/ml/rag/test_utils.py that parses the string with ast and builds the value from the syntax tree. Only literals, lists, tuples, dicts and the Chunk, EmbeddableItem, Content, Embedding and defaultdict constructors are accepted; nothing is evaluated. The replacement also accepts EmbeddableItem, which is what repr() of a Chunk prints since Chunk became an alias. The old helper could not parse that output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.