Repository navigation
Bump org.apache.maven:apache-maven from 3.9.16 to 3.10.0 - #27191
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps org.apache.maven:apache-maven from 3.9.16 to 3.10.0. --- updated-dependencies: - dependency-name: org.apache.maven:apache-maven dependency-version: 3.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
✅ Generated files are up to dateAn earlier CI run reported uncommitted generated changes; the latest run no longer does. |
davsclaus
left a comment
There was a problem hiding this comment.
Thanks for the bump! Maven 3.10.0 is GA (still Java 8+, now on Resolver 2.0.24), and the CI log shows the full -Pregen install and the camel-catalog install both succeeding with ./mvnw on 3.10.0, which is a good sign for its stricter POM validation.
The two red build checks are not Maven failures: they come from the "uncommitted changes" guard. Dependabot's wrapper updater committed mvnw.cmd with CRLF in the index, but .gitattributes declares mvnw.cmd text eol=crlf (LF in the index, CRLF on checkout), so a fresh checkout reports the file as modified. mvnw.cmd should simply be dropped from this PR (its content is unchanged; it's wrapper 3.3.4 either way), or renormalised with git add --renormalize mvnw.cmd.
The updater also stripped the ASF license header from .mvn/wrapper/maven-wrapper.properties. RAT excludes .mvn/**, so nothing fails, but we have kept the header there and should keep it.
Minor: .sdkmanrc still pins maven=3.9.16; it is usually updated together with the wrapper.
Note this PR is independent of #27192 (the maven-version property for the Maven libraries our plugins/launcher compile against). Upgrading the build tool does not require #27192.
Claude Code on behalf of davsclaus
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
| wrapperVersion=3.3.4 | ||
| distributionType=bin | ||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.16/apache-maven-3.9.16-bin.zip | ||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.10.0/apache-maven-3.10.0-bin.zip |
There was a problem hiding this comment.
The version bump is fine, but this file lost its ASF license header (lines 1-16 on main). Please restore it; Dependabot's wrapper updater regenerates the file without it.
|
ℹ️ CI did not run targeted module tests. |
davsclaus
left a comment
There was a problem hiding this comment.
Thanks @gnodet for the regen. mvnw.cmd has dropped out of the diff, and both build jobs are green on 97216cd, so the 3.10.0 wrapper builds Camel cleanly.
Two things are still open before this leaves draft: .mvn/wrapper/maven-wrapper.properties still loses the ASF license header (existing thread), and .sdkmanrc still pins maven=3.9.16, which should move to 3.10.0 together with the wrapper. The branch now has a manual commit, so Dependabot will not rebase it anymore, and these need to be pushed by hand.
This is still independent of #27192, which raises the minimum Maven for our plugins.
Claude Code on behalf of Claus Ibsen
Bumps org.apache.maven:apache-maven from 3.9.16 to 3.10.0.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)