IO-879: Restore read-only state after failed deletion - #881
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes IO-879 by restoring a file's read-only state when an override-enabled deletion attempt fails.
Changes
PathUtils.deleteFilewhen the file remains after a failed deletion.DeletingPathVisitorandCleaningPathVisitor.Testing
mvn -pl . -Dtest=PathUtilsDeleteFileTest -Dsurefire.failIfNoSpecifiedTests=false test -q— passed locally: 8 tests, 1 skipped (Windows-only regression skipped on macOS).mvn -DskipTests compile -q— passed.git diff --check— passed.mvn test— not completed: the suite continued running without producing new reports for several minutes on macOS/JDK 27, so the local process was stopped rather than reported as passing.Notes
The change preserves the original deletion exception and only restores the attribute when the path still exists. AI assistance was used during investigation and implementation; the submitter reviewed the changed lines and test results.