Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2842 +/- ##
============================================
- Coverage 56.12% 53.02% -3.11%
- Complexity 976 1316 +340
============================================
Files 119 168 +49
Lines 11743 15267 +3524
Branches 2251 2517 +266
============================================
+ Hits 6591 8095 +1504
- Misses 4012 5966 +1954
- Partials 1140 1206 +66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
commented
Dec 3, 2025
|
|
||
| val tagValue = node.getTagValue(CometExplainInfo.EXTENSION_INFO) | ||
| val str = if (tagValue.nonEmpty) { | ||
| val str = if (tagValue.exists(_.nonEmpty)) { |
Member
Author
There was a problem hiding this comment.
This stops false reporting of empty fallback reasons
CometExecRule to improve handling of scan transformations [WIP]CometExecRule to improve handling of scan transformations
andygrove
marked this pull request as ready for review
December 3, 2025 16:39
andygrove
marked this pull request as draft
December 3, 2025 17:20
Member
Author
|
This is now superseded by #2844 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The code prior to this PR has match arms for
CometScanExecandCometBatchScanExecwith conditions so that they only execute for native scans. Hybrid scans are handled in the genericisCometSinkhandling, which then has scan-specific logic.This PR refactors the scan handling to fit into the serde framework, with separate implementations for native and hybrid scans. The hybrid scans extend
CometSink. The genericisCometSinkhandling no longer refers to scans.What changes are included in this PR?
How are these changes tested?